Giter Site home page Giter Site logo

Comments (6)

jorgebucaran avatar jorgebucaran commented on May 13, 2024 1

I just added Windows support in 2.0.1. 👋

from nvm.fish.

jorgebucaran avatar jorgebucaran commented on May 13, 2024

@Skehmatics Haha, you did the right thing. How can I get started working on this?

from nvm.fish.

Skehmatics avatar Skehmatics commented on May 13, 2024

To get the binaries, setting OS to win when detecting uname -s starting with MSYS_NT, as well as handling that the archive type will be .zip or .7z (modern tar can still extract these) rather than the hardcoded .tar.gz will be enough (see PR #96 )

I'm not sure how adding the binaries to the path works, however. We'll have node.exe (which will be aliased to just node by msys) and npm (no .exe for this one, apparently)

from nvm.fish.

Skehmatics avatar Skehmatics commented on May 13, 2024

Oh, duh, the other archives have the binaries in /bin, while the windows ones are just scattered about.

from nvm.fish.

RayBenefield avatar RayBenefield commented on May 13, 2024

Hey @jorgebucaran

So just spent quite a bit of time debugging some stuff.

First is the switch check for the $os won't catch the proper case as you pipe it through string lower and the case check is in caps.

Second it doesn't seem like gzip is a big fan of .zip files if they have more than one file in them. See: https://superuser.com/questions/1237854/gzip-stdin-has-more-than-one-entry-rest-ignored-and-gzip-tmp-gz-has-more-t

On top of that the structure of the zip file isn't the same as other OSs... you'll get npm is actually in node_modules/npm not at the root of the directory like node so when you nvm use it tries to find the package.json at $v/bin/npm/package.json when it is actually at $v/bin/node_modules/npm/package.json.

It's all a mess... I have to dip for now. But wanted to at least put this all down before heading out.

from nvm.fish.

jorgebucaran avatar jorgebucaran commented on May 13, 2024

@RayBenefield I added Windows support a few weeks ago. Are you saying it isn't working for you?

from nvm.fish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.