Comments (5)
Hm.. I don't know. Do you check your beam files or your erl files? The beam files (compiled with debug_info) should contain the AST after parse transform. The erl files contain the code before parse transform.
It is possible to inform gradualizer about such functions, or override specs with other specs, by loading a module with spec declarations such as -spec lager:debug(_, _) -> ok.
using the gradualizer_db
functions import_module/1, import_erl_files/1 and import_beam_files/1. These are internal but you can use them to check if it solves the problem. We should add an option to include such files for the cli command and for the gradualizer:type_check_* functions where options are used.
from gradualizer.
I've finally had time to check this. Indeed, typechecking .beam files works without an issue:
$ cat src/lager_tracing.erl
-module(lager_tracing).
-compile([export_all]).
-include_lib("lager/include/lager.hrl").
log_event_with_tag() ->
lager:warning([{tag, true}], "warning with tag ~p", ["{tag, true}"]).
log_event_no_tag() ->
lager:warning("warning without tags", []).
$ gradualizer src/lager_tracing.erl
src/lager_tracing.erl: Call to undefined function lager:warning/3 on line 8
src/lager_tracing.erl: Call to undefined function lager:warning/2 on line 11
$ gradualizer -pa _build/default/lib/lager/ebin _build/default/lib/lager_tracing/ebin/lager_tracing.beam
$
So does importing spec stubs with gradualizer_db
.
I think the CLI flag would be a huge plus. Thanks for the response. I'll leave this issue open for you to decide if it's a good reminder for the flag feature or should just be closed.
from gradualizer.
Thanks for verifying this!
from gradualizer.
I think it would make sense to have a CLI flag in the long term. But given that we have a work-around that works well I don't consider it a high priority.
from gradualizer.
For the record, it's been a while since I created this issue and it turns out the original problem - false warnings about lager
- is now easily solvable.
The --specs_override_dir
fits the purpose of overriding specs. Used together with the following lager.specs.erl
file, the Lager warnings are gone:
-module(lager).
-spec lager:debug(string(), list()) -> ok.
-spec lager:info(string(), list()) -> ok.
-spec lager:warning(string(), list()) -> ok.
-spec lager:error(string(), list()) -> ok.
-spec lager:critical(string(), list()) -> ok.
Since I use Vim, I made the Neomake gradualizer maker (https://github.com/erszcz/neomake/tree/erlang-gradualizer-wip @ 285c6232) use --specs_override_dir
. Coupled together with a project-local .vimrc
:
let g:neomake_erlang_gradualizer_specs_override_dir = '/Users/erszcz/work/my_project/priv/gradualizer_overrides'
the warnings are gone for the whole project. Works great!
I'm closing the issue, since there's a CLI flag now, and the original problem is solved.
from gradualizer.
Related Issues (20)
- Crash with Uncaught error: function_clause HOT 6
- Crash with `Uncaught error: {case_clause, ..` in `typechecker:do_type_check_expr/2`
- Crash with Uncaught error: {badkey, ...} HOT 1
- No clause for gradualizer_lib:pick_value(module()) HOT 2
- No clause of gradualizer_lib:pick_value(any()) HOT 2
- Support the new dynamic() type
- `ok bsr ok` crashes erl_eval:do_apply/7 HOT 4
- An invalid utf32 value can crash eval_bits:eval_exp_field/6
- Crash in gradualizer_fmt:format_type_error: no function_clause_matching
- Crash in typechecker:do_type_check_expr_in/3: bad_key in map_get/2
- Invalid polymorphic code accepted HOT 2
- Support old-style 'catch' keyword HOT 5
- Wrong type in receive...after Timeout
- `binary_to_atom/1` breaks compatibility below OTP 23 HOT 4
- Solving local constraints at each function call to a polymorphic function HOT 6
- support for OTP 26 map comprehensions
- Wrong type location reported?
- Gradualizer can't tell that `m` and `f` don't exist in `erlang:apply(m, f, [some, args])` HOT 2
- Exhaustivity checking issue
- Type representation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gradualizer.