Comments (4)
Good first point.
About the second, should we respect if the user has already assigned hydrogens to a mol, even if they don't correspond with OBabel's choice? Sounds a bit too aggressive to me.
from delfta.
Hm, depends. I think the case where only some of the hydrogens are explicit but others are not would likely give strange results, since all the molecules in the training set had all their hydrogens added. Although that would lie in the user's responsibility, if they decide to explicitly set addh=False
.
from delfta.
I'd make addh=True
by default though - it doesn't change anything if hydrogens are present, and if they are not we add them. If someone disabled that and get's strange results, that's on them.
from delfta.
Fixed with 1472e38
from delfta.
Related Issues (20)
- Benchmark speed
- Make sure the calculator uses the optimized mol if xtbopt=True HOT 1
- Check windows installation HOT 1
- bond order calculation when calling run_xtb_calc
- covalent bond check between openbabel & xtb
- Add WBOs to test_calculator.py
- Provide single-task models for all endpoints
- Profile code via vTune
- Independent results for 3 runs of EGNN over QM9
- Set xTB environment variables automatically
- Parallelize xtb code
- Remove `offset_idx` function argument in calculator
- xtb refactor for fully-connected graph HOT 2
- add ignore_checks flag in calculator
- tarfile.ReadError HOT 3
- Installation: Docker image missing libXau.so.6 HOT 1
- Support for python 3.9 and deprecate 3.7
- E_gap doesn't always equal E_lumo - E_homo HOT 1
- Using QMugs as a Pytorch Geometric dataset HOT 1
- Cannot download files HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delfta.