Giter Site home page Giter Site logo

Comments (4)

josejimenezluna avatar josejimenezluna commented on June 19, 2024

Good first point.

About the second, should we respect if the user has already assigned hydrogens to a mol, even if they don't correspond with OBabel's choice? Sounds a bit too aggressive to me.

from delfta.

cisert avatar cisert commented on June 19, 2024

Hm, depends. I think the case where only some of the hydrogens are explicit but others are not would likely give strange results, since all the molecules in the training set had all their hydrogens added. Although that would lie in the user's responsibility, if they decide to explicitly set addh=False.

from delfta.

cisert avatar cisert commented on June 19, 2024

I'd make addh=True by default though - it doesn't change anything if hydrogens are present, and if they are not we add them. If someone disabled that and get's strange results, that's on them.

from delfta.

josejimenezluna avatar josejimenezluna commented on June 19, 2024

Fixed with 1472e38

from delfta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.