Failures with parser-2.3.0.6

[joshcheek]

Failures with parser-2.3.0.6

[JoshCheek]

How to fix the issue!!

You should be able to get a working version now, with $ gem install seeing_is_believing --version 3.0.0.beta.7 I understand that I should obviously just release v3.0, but give me 3 months more, and then you can yell at me and I'll say "yes, you're right". Part of the problem is the implication of major versions, so I pushed a lot of changes towards this, rather than feeling comfortable releasing them incrementally :(

Commits

Here are all the commits since last release.

Synopsis

They pushed a newer version of parser, largely b/c of this issue, 4 days ago. I just released a new version of SiB https://rubygems.org/gems/seeing_is_believing/versions/3.0.0.beta.7

• The largest issue was due to changes which disallowed multiple insertions at the same location (change is here). When I discovered the issue, I pointed out SiB's use case here. Parser added an API to re-enable this functionality, largely b/c SiB needs it, here.
• The ability to edit invalid files was temporarily lost, I whined about it and they pointed out that there's a way better way to do it than I was doing, so now it's back.
• Some tests were failing b/c of this, I just removed them, here
• Found a bug in MRI and Parser, which is now fixed.
• I also fixed a bug around explicit warning, while I was in there.
• A while back, an unreleased fix on recording instances of BasicObject got added here

I think that's most of it. The crux of it is that my deps updated while I was busy, and SemVer wasn't sufficient to imply that they would break SiB, so when they updated, the newer deps got downloaded and ran with SiB,

[lcguida]

I've experienced the same problem. Rolling back the parser gem version to 2.2.3.0 worked.

[terlar]

I experience the same thing and but with the seeing_is_believing vim plugin. And I cant downgrade the version because rubocop requires a higher one.

[JoshCheek]

Aye. They have a newer version that probably works. I've been intending to try to upgrade, but too many plates to keep them all spinning. If anyone wants to try restricting the version or updating the code, I'm happy to pull (prob ping me on Twitter, issues get lost in my inbox).

• I initially brought up the issue here
• They have a new version that probably works here
• The code that will need to be changed is here
• The tests for that code are here
• Last push failed CI here I haven't looked into why, but a quick glance says it's to do with exit statuses. However, that's the binary code. So prob run other tests first, might be blowing up for other reasons, and this just shows up b/c of the error message.

[JoshCheek]

Oh, in the interim, you can specify the version to use for a gem with a special argument (eg if you can't an an env var)

$ rails -v
Rails 4.2.5

$ rails _4.2.2_ -v
Rails 4.2.2

[JoshCheek]

I've got it mostly there. It fixes this common issue (against Parser's HEAD, the change isn't released yet). But other changes prevent it from extracting valid comments (ie clearing the annotations partway through an edit that leaves the file in an invalid state).

[mann]

I was trying to get seeing_is_believing (s_i_b) working with Sublime Text 3 and was also getting a parser error. It was suggested by Josh to downgrade from my current parser gem of parser-2.3.0.6 to parser-2.2.2.6 by doing a gem uninstall parser, then reinstall the older version with gem install parser --version 2.2.2.6. That's is the parser version s_i_b was written against. This worked for me! I verified by running this at the terminal with seeing_is_believing -e '1+1' which printed out 1+1 # => 2, I also verified by going into sublime and writing something in ruby to be evaluated (eg. 2 + 2). That worked too.

[avdi]

Thanks a lot, Josh!

On Tue, Mar 29, 2016 at 11:55 PM Josh Cheek [email protected]
wrote:

How to fix the issue!!

You should be able to get a working version now, with $ gem install
seeing_is_believing --version 3.0.0.beta.7 I understand that I should
obviously just release v3.0, but give me 3 months more, and then you can
yell at me and I'll say "yes, you're right". Part of the problem is the
implication of major versions, so I pushed a lot of changes towards this,
rather than feeling comfortable releasing them incrementally :(
Commits

Here
252911d...e73fced
are all the commits since last release.
Synopsis

They pushed a newer version of parser, largely b/c of this issue, 4 days
ago. I just released a new version of SiB
https://rubygems.org/gems/seeing_is_believing/versions/3.0.0.beta.7

• The largest issue was due to changes which disallowed multiple
  insertions at the same location (change is here
  whitequark/parser#277). When I discovered
  the issue, I pointed out SiB's use case here
  whitequark/parser#259 (comment).
  Parser added an API to re-enable this functionality, largely b/c SiB needs
  it, here whitequark/parser#277.
• The ability to edit invalid files was temporarily lost, I whined
  about it whitequark/parser#281 and they
  pointed out that there's a way better way to do it than I was doing, so now
  it's back
  add87f1
  .
• Some tests were failing b/c of this
  whitequark/parser#283, I just removed
  them, here
  add87f1
• Found a bug in MRI https://bugs.ruby-lang.org/issues/12073 and
  Parser whitequark/parser#274, which is now
  fixed.
• I also fixed a bug
  #59 around
  explicit warning, while I was in there.
• A while back, an unreleased fix on recording instances of BasicObject
  got added here
  37ad246

I think that's most of it. The crux of it is that my deps updated while I
was busy, and SemVer wasn't sufficient to imply that they would break SiB,
so when they updated, the newer deps got downloaded and ran with SiB,

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#69 (comment)

[lcguida]

Thanks 👏

[Jpease1020]

My favorite tool is back!