Tests!

[joshwcomeau]

Tests!

[mirkojotic]

@joshwcomeau Hey, I'd like to take one or more of above if I can do so on Linux. If its possible I'd start from the beginning with task.reducer.js.

[mik639]

Hi @joshwcomeau
I have some tests for dependencies reducer here #76

[AbhiPrasad]

Hey, just came across this project and I love the idea!

I would love to write some tests to get familiar with the codebase. I can start off with projects.reducer.js and maybe write some more after that.

Also, I can help implement some CI integration to run tests after I get some of these done!

[joshwcomeau]

@Leodau awesome! Glad for the help :D

As @superhawk610 points out, that one has some cross-platform implications.

If you want a good first task, how would you feel about creating some React Storybook stories for some of our reusable components? There isn't an issue for it yet, but we were just talking about it in #28 (comment). If you're interested, let me know, I'll create an issue and we can start working on top priorities :)

[superhawk610]

@Leodau thanks for your willingness to help! Feel free to open a PR once you have added your tests.

If you're developing on Windows, you may want to take a look at @bennygenel's windows-support branch and my PR as it fixes find-available-port.service.js function when running from Git Bash on Windows.

[joshwcomeau]

Hi @Leodau!

Sorry for the delay - I'm speaking at a conference this week and so I've been neglecting this project as I prepare for that D: I should get much better at quick responses starting next week =)

@AWolf81 has started doing the foundational work to get React Storybook set up. I believe that work is almost done (was surprisingly tricky, because this is an Electron project and Storybook runs in the browser). Once that's merged, you'll be able to create some stories for our components :)

I'm gonna create the issue now with all the info.

Sorry again for not getting back to you for a few days! Hope you're still motivated to contribute :)

[joshwcomeau]

Thanks for the great work, y'all!

Also, I can help implement some CI integration to run tests after I get some of these done!

That'd be awesome! Now that we actually have some tests, it'd be great to ensure new changes are validated.

@mirkojotic the newest version runs on linux :) no pressure but if you're still interested, now's a great time!

[scottwarren]

@joshwcomeau I started adding tests for the location.service.js/Location Service in #113

EDIT: and I've finished... 🚀

[scottwarren]

Added some more tests, for project-name.service.js and project-type-specifics.js in #114

In the same PR, I added a couple of tests for create-project.service.js too, but it's not testing each function in that module.

[Leodau]

Hey @joshwcomeau, am interested in taking "find-available-port.service.js"
being a newbie in open source myself such a good oportunity!

[Leodau]

@joshwcomeau I like the idea of the stories!
Thank you guys.

[joshwcomeau]

I actually think we've made tremendous progress on the tests!

I'm gonna close this issue since there isn't much "low-hanging fruit" left. As we develop, I'll keep an eye out for "good first issue" test opportunities though