Comments (2)
Found and corrected typos in the wiki.
from simplecfd.
Currently in the variable density versions of the code the following happens in terms of factors of rho
The old ( "t=n" ) density is used in
- step 2: this is uncontroversial
- step 3: There is a question over whether advect_dens should occur before this (immediately after step_2) and then a half time density can be computed for use in this step (you would also need to flesh out the code for step 3 which assumes a lot of things don't change but now do with the different factor of rho). This is what seems to happen in
lm_atm
inpyro2
.
The half time (t=n+1/2) density is used in:
- step 4: gravitational source /forcing for the beta/rho or 1/rho coefficient (seems appropriate). (NB only in the atmospheric code, the other versions have not been updated yet and use the n+1 value for rho).
The new (t=n+1) density is used in:
- step 4: for the 1/rho coefficient in front of the lagged pressure (this seems inappropriate)
- all of step 5: seems appropriate.
In other words:
-
Should
advect_dens
be called beforestep_3
, and used in the updated interface states ? (as it is inpyro2 lm_atm
? Remember, step_3 would have to be fleshed out in this case - it basically assumes nothing changes except for a new up-winding. -
Should you use a half time rho for all coefficients in step_4? (i.e. not just for gravity in the case of the atmospheric version, and if so update other versions consistently.)
from simplecfd.
Related Issues (20)
- CCAPS - No Slip + Grav issue HOT 8
- CCAPS IO - slow python startup times are a bottle neck HOT 1
- CCAPS_atm_const - possible correction bug HOT 1
- CCAPS (all flavours) - RTI bug (and avoid hard-coding of fixed eta for MG boundary) HOT 17
- CCAPS (all flavours) - add reporting of MG boundary conditions to setup_report HOT 1
- CCAPS - remove (redundant) warning messages that MG is hardcoded to periodic HOT 1
- CCAPS - double check the gravitational dt
- CCAPS variants : update the welcome message to indicate which flavour of code used
- CCAPS - test "slip" bc and roll out to all vars HOT 1
- CCAPS - possible missing rho bc application in step_2 HOT 1
- CCAPS_vardens - incorporate new bc and problems HOT 1
- CCAPS_atm - incorporate new bcs (where appropriate) and drop problem HOT 2
- CCAPS (all): Refactor so that each problem setup/diagnostic can be self contained in own module
- Maths in wiki has stopped rendering properly
- remove stray debug code from ccaps advance_module
- Does the analytical solution in multigrid test 5 have a typo? HOT 2
- MG - add time-independent test for the const coeff helmholtz HOT 1
- MG - test3 - is it okay? HOT 3
- MG / CCAPS - see if OpenMP is worthwhile HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simplecfd.