Not compatible with pyjwt 0.3 because decode method signature has changed.

[jpadilla]

Not compatible with pyjwt 0.3 because decode method signature has changed.

[hoIIer]

! just ran into this and was wondering what was going on... glad to know its documented

[jpadilla]

Hey @caffodian @Epicowl sorry about this, I just released that new version of PyJWT and totally screwed up there. I'm going to release a new version of PyJWT tonight that will fix the signature.

[jpadilla]

Actually by checking these PRs, I think where I had screwed up was in this project by using positional arguments. But still should have probably noted this for PyJWT.

[vforgione]

Yeah. I linked to the new method signatures in my PR. Just throwing the argument names on jwt_decode_handler for the last two positionals fixes it.

[caffodian]

I'm kind of a fan of just fixing it over here and maybe tightening some of the requirements.txt versioning if think it'll change more in the future.

releasing a PyJWT version to revert it would only really fix it for anyone that has drf-jwt frozen at 1.0.1, doesn't have PyJWT explicitly defined, and won't come here to check the issues ;)

[jpadilla]

@caffodian good idea. Thoughts on locking down the requirements for PyJWT at 0.3.0 for now?

[caffodian]

@jpadilla Perhaps lock it at >=0.3,<0.4 , and just make sure any breaking changes go into a 0.4 on the PyJWT side? It'll let you seamlessly put in other minor fixes that this package can benefit from in the meantime (0.3.1 etc)

[jpadilla]

Just released 1.0.2 and already should be published on PyPI.

[vforgione]

Everything looks good. Thanks for jumping on this so quickly!