Support querySelector and querySelectorAll

[avanderhoorn]

Support querySelector and querySelectorAll

[JPeer264]

Thanks for your issue. Hm that is weird, it should compile. Does everything else in the javascript file compile right?

Moreover, are #js-carousel, .js_slide and #js-slider-indicators included in any precompiled css file? Because gulp-rcs, and any other rcs-core plugin, will compile all id's and classes based on the css files.

[avanderhoorn]

I think I found the problem. You were correct in suggesting that those id/classes weren't a part of any style sheet, there were just present in the HTML and JS... at first glance when things weren't working, this stood out, hence why I suggested it. The real problem comes down to:

    preloadSlide('#js-carousel-slide-1', '/img/front-page/hero1.svg', function () {
        carousel.className += ' is-initialized';
    });

vs

    preloadSlide('#js-carousel-slide-1', '/img/front-page/hero1.svg', function () {
        carousel.className += 'tU';
    });

In the above you can see that rcs isn't preserving white in the strings in js files. I was thinking of just going ' ' + 'is-initialized'; to work around this bug, bug given the asset generation pipeline, uglify has already run by this stage and would have optimized the above back to ' is-initialized';.

Any chance you think this might be an easy fix?

[JPeer264]

Oh yes, that is indeed a bug. I will try to fix this asap.

Btw, usually it is recommended to run gulp-rcs or similar before uglifying the code - so I am not yet sure if there would be some other bugs, if so please let me know.

[avanderhoorn]

Will do and thanks for your help! I'll see what I can do to switch tasks around.

[JPeer264]

A possible workaround for now would be following:

...
    preloadSlide('#js-carousel-slide-1', '/img/front-page/hero1.svg', function () {
        var whitespace = ' ';

        carousel.className += whitespace + 'is-initialized';
    });
...

[avanderhoorn]

Ya I thought about that, have to see what it produces.

[avanderhoorn]

WHOOT! Thanks for the quick response. Will this require a rev to the package gulp-rcs to get this update or just this one?

[JPeer264]

Nope, I will update gulp-rcs in couple of minutes (I'll notify you). I just had troubles with some other dependencies in Node v<6 😅

[JPeer264]

@avanderhoorn you can now install [email protected]. Happy coding ✌️ - and please let me know, if you have any other issues 👍

[avanderhoorn]

Huge thanks!!! 👍