Giter Site home page Giter Site logo

Comments (8)

JPeer264 avatar JPeer264 commented on June 12, 2024 1

@klimashkin thanks for your issue. Oh yes passing the options to espree directly would be great indeed. I will work on that as soon as I have time 👍

from node-rename-css-selectors.

klimashkin avatar klimashkin commented on June 12, 2024 1

Awesome, it works! Thank you!

from node-rename-css-selectors.

klimashkin avatar klimashkin commented on June 12, 2024

In general it would be great to have a way to pass options from processJs to espree directly (add some espreeOptions param), because sometimes we want to stop transpiling some ES20XX features without waiting for a whole ES20XX spec to be finalized, as browsers start supporting it

from node-rename-css-selectors.

klimashkin avatar klimashkin commented on June 12, 2024

Probably as a fast fix you could release minor update of node-rcs-core that will require espree as ^4.0.0-rc.0 || ^4.0.0.
Spec will not be changing and seems like they just wait it to be published to bump final 4.0.0

from node-rename-css-selectors.

JPeer264 avatar JPeer264 commented on June 12, 2024

The problem is, I just checked, I am not using espree (it was accidentally in the dependencies). I use recast which is using esprima under the hood. I now have to think about the solution right now, as I can switch the parsers from recast. I hope I will find a general solution

from node-rename-css-selectors.

klimashkin avatar klimashkin commented on June 12, 2024

Oh, my bad, I was sure I saw espree in the source.
I think problem with esprima is that it's jquery project that is not really maintained anymore.
espree is better because it uses acorn, which is being developed pretty good.

from node-rename-css-selectors.

JPeer264 avatar JPeer264 commented on June 12, 2024

Yap, I thought about the same. I think espree is the way to go.

from node-rename-css-selectors.

JPeer264 avatar JPeer264 commented on June 12, 2024

With v2.0.0 it should be fixed, and your options are now added. For that, please check out the parserOptions.

from node-rename-css-selectors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.