Changing the nameGenerator

[jpeer264]

Changing the nameGenerator

[JPeer264]

Hi, thanks for your issue. This is actually a greay idea and not hard to implement (as far I could think of).

You have any idea what kind of function you want to pass as alternative nameGenerator? Maybe we can pass another generate function?

[X-Ryl669]

It's in rcs-core now!
Preventing ad is indeed possible with the upcoming reserve array in the config file. These won't be generated anymore (without tweaking with the name generator at all). Yet, you can write your own too, and you'll have the information about what needs to be generated as the second argument (so when given an attribute selector, just call the default generator).

[pacifier007]

Yes, a way to pass in our own generator function would be awesome. This is an article with excellent example of a custom name generation method used in conjunction with generateScopedName feature of babel's css-modules plugin.

IMHO, we don't really need something that extensive. A simple option to use a custom name generator function will do.
'generator': className => { .. }

[JPeer264]

Hey @pacifier007. I introduced useCustomGenerator in this PR JPeer264/node-rcs-core#64. I am still not quite done yet because I need your help. In useCustomGenerator you have to pass in a function where a object is passed as parameter. In this object type is a key which the possible values: keyframe, selector or attributeSelector.

The only thing is that I have troubles with the type attributeSelector as you, as user, have to know what kind of attribute selector it is, that it won't crash the attribute selectors. The type attributeSelector means, that this passed class is matching any attribute selector of your passed CSS files.

As a small example what I mean. Let's say you have an attribute selector [class=^begin], then you have to keep begin in the beginning of every class which matches it. So here my question. How do you want to handle such cases? Should I pass two extra keys with 1. the matching character: e.g. ^ or $ and 2. the key what should stay the same? Or should I just pass the tail of the classes. E.g. if the class is beginners then I would just pass ners so you do not have to worry about the validation.

Or do you have another idea how it would make sense?

[JPeer264]

ping @pacifier007