Giter Site home page Giter Site logo

Comments (7)

jpenilla avatar jpenilla commented on May 25, 2024 1

You could consider this as well:
2LStudios-MC/CleanMotD#7 (comment)

Like is mentioned in the issue you linked, the Via API is useless here, as I do not have a Player object during the ping event on Paper/Bukkit, and like I mentioned before, having Via installed will cause all pings to report to the event as up to date, and Via handles downsampling the colors.

It seems like on Velocity/Bungee the reported protocol version is actually correct even when Via is installed, so it's a possible feature to add for proxies.

from minimotd.

PhanaticD avatar PhanaticD commented on May 25, 2024 1

please add this at least for the proxies

from minimotd.

EnderGamingFilms avatar EnderGamingFilms commented on May 25, 2024

I was thinking this, I believe there should be a way to use ProtocolLib or ViaVersion to tell which client a player is pinging the server with. And minimotd could use that to determine which motd to show them

from minimotd.

jpenilla avatar jpenilla commented on May 25, 2024

As of now, there is no API for this in ViaVersion.

Meaning, this feature as requested would break when used in combination with ViaVersion as ViaVersion will cause the ServerListPingEvent to always report using the server's protocol version, with no way to get the client's actual protocol version.

The reason that all clients reporting as up to date with ViaVersion works fine currently, is that since MiniMOTD believes it is an updated client it sends RGB text, which ViaVersion then internally downsamples using the same API that I do in MiniMOTD.

from minimotd.

EnderGamingFilms avatar EnderGamingFilms commented on May 25, 2024

I see the issue with that. How about without "ViaBackwards" and having a motd for those outdated clients?

from minimotd.

kaxlabs avatar kaxlabs commented on May 25, 2024

You could consider this as well:
arkflame/CleanMOTD#7 (comment)

from minimotd.

EnderGamingFilms avatar EnderGamingFilms commented on May 25, 2024

You could consider this as well:
2LStudios-MC/CleanMotD#7 (comment)

Like is mentioned in the issue you linked, the Via API is useless here, as I do not have a Player object during the ping event on Paper/Bukkit, and like I mentioned before, having Via installed will cause all pings to report to the event as up to date, and Via handles downsampling the colors.

It seems like on Velocity/Bungee the reported protocol version is actually correct even when Via is installed, so it's a possible feature to add for proxies.

I know this is not very good for design, but I would be very grateful if you implemented this on bungee/waterfall & velocity. This makes it a limited feature but I still think most of the users who use your plugin would appreciate it. I also think anyone investing in a server should look up how proxies can benefit them even if they only use a single server setup 🙂

from minimotd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.