moment dependency?

[jwasilgeo]

moment dependency?

[jwasilgeo]

Is it a dependency of the calcite-react/DatePicker, since it is supplied directly to the DatePicker on https://github.com/jpeterson/arcgis-filter/blob/master/src/ArcgisFilter/components/ValueInput.js#L64?

[jpeterson]

@jwasilgeo this is a good catch. I was building arcgis-filter and calcite-react simultaneously and the fact that moment is a dependency of calcite-react is why this never actually breaks anything...

We should probably rethink whether to go all in on moment, or to only use date-fns within this project. The benefit of using moment is that we can work directly with moment primitives provided by calcite-react/DatePicker. So maybe we replace any usage of date-fns with moment and add moment as a peerDependency?

[jwasilgeo]

On it.