Comments (5)
Testing the fix now. I'm adding automated tests for all processing operations on NodalData (except ungap and merge, which are currently inapplicable). Since the structure has significant differences from SeisData and EventTraceData, I want to be sure that you don't run into problems further down the line.
Incidentally, how do views of an Array{Float32, 2} (equivalently, Matrix{Float32}) behave on GPU with your package?
from seisio.jl.
Fixed on dev
from seisio.jl.
Views work just the same as normal arrays but I believe they have to be contiguous. Views do not interact well with transposes or reshapes at the moment - JuliaGPU/Adapt.jl#21
but apparently a fix could be on the way at some point JuliaLang/julia#31563
from seisio.jl.
Perfect. I'm pretty sure I have no transpose or reshape calls in SeisIO processing functions at the moment. Eventually, as your group gets further into nodal arrays, you'll be able to write NodalData processing methods into the submodule for two-dimensional FFTs on the underlying :data
field. So, I think this will need only a minor tweak to allowed data types to be fully GPU compatible.
from seisio.jl.
Fixed on master and in the new release. Will close this issue as soon as Julia Registrator merges my PR(s).
from seisio.jl.
Related Issues (20)
- TagBot trigger issue HOT 2
- sync!(C::SeisChannel) does not update C.t HOT 1
- Strange behavior with get_data!() HOT 1
- read_data fails on file with fs == 0 HOT 1
- filtfilt! converts all data to NaN HOT 14
- Failing DataFormat test on julia 1.6.1 HOT 11
- ArgumentError on reading ASDF file HOT 1
- SeisIO prevents other packages to be updated HOT 5
- Support for another Q files? HOT 3
- Malformed SeisChannel ID (station code) in `read_sac_stream` HOT 4
- Can't read multiple SAC files using `read_data` HOT 2
- Using SeisIO to read metadata file (format of resp) with errors?
- Transition test file download from SVN to Base.download? HOT 2
- How to read an entire list of sac files? HOT 4
- Very slow mseed read time
- SeisIO v1.2.1 fails to compile on M1 Mac
- ERROR:LoadError:unable to open libLLVM
- LoadError: There was an error during testing HOT 4
- Error during data testing-Utils/test_units HOT 2
- Fail to compile _Fixed (see the attached copy) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seisio.jl.