segfault with http when client publish without user

[jpmens]

segfault with http when client publish without user

[jpmens]

Please show your mosquitto.conf (without passwords), as well as a description of the HTTP service you're using.

[pat1]

my mosquitto.conf:
pid_file /var/run/mosquitto.pid
persistent_client_expiration 1d
persistence true
persistence_location /var/lib/mosquitto/
log_dest stdout
log_type debug
log_type error
log_type warning
log_type notice
log_type information
connection_messages true
log_timestamp true
include_dir /etc/mosquitto/conf.d

included rmap.conf file:
auth_plugin /home/pat1/svn/mosquitto-auth-plug/trunk/auth-plug.so
auth_opt_backends http
auth_opt_http_hostname localhost
auth_opt_http_ip 127.0.0.1
auth_opt_http_port 8100
auth_opt_http_getuser_uri /auth
auth_opt_http_superuser_uri /superuser
auth_opt_http_aclcheck_uri /acl

I use for my test http-auth-be.py in example directory

the patch below solve the problem for me but I think it is not clean:

--- cache.c (revisione 125)
+++ cache.c (copia locale)
@@ -61,6 +61,9 @@
unsigned char hashdata[SHA_DIGEST_LENGTH];
int mdlen, i;

• if (username == NULL) return;

data = malloc(strlen(clientid) + strlen(username) + strlen(topic) + 20);
sprintf(data, "%s:%s:%s:%d", clientid, username, topic, access);

[jpmens]

Thanks for your hints, I think you're right. I have pushed a fix which will not attempt to cache null usernames. I have also pushed a fix which sets a default for anonusername (see README.md).

Could you test if this solves the issue for you?

[pat1]

Il giorno dom, 23/11/2014 alle 13.17 -0800, JP Mens ha scritto:

Thanks for your hints, I think you're right. I have pushed a fix which
will not attempt to cache null usernames. I have also pushed a fix
which sets a default for anonusername (see README.md).

Could you test if this solves the issue for you?

Thanks, it works !

1416778024: New connection from 192.168.1.172 on port 1883.
1416778024: New client connected from 192.168.1.172 as mosqpub/6505-asus-pat1 (c1, k60).
1416778024: Sending CONNACK to mosqpub/6505-asus-pat1 (0)
1416778024: |-- mosquitto_auth_acl_check(..., mosqpub/6505-asus-pat1, anonymous, /test, MOSQ_ACL_WRITE)
1416778024: |-- url=http://127.0.0.1:8100/superuser
1416778024: |-- user anonymous was authenticated in back-end 0 (http)
1416778024: |-- url=http://127.0.0.1:8100/acl
1416778024: |-- aclcheck(anonymous, /test, 2) AUTHORIZED=0 by http
1416778024: |-- Cached [77002C9B194B464613C22FB1521CDBC2B0EBD2BB] for (mosqpub/6505-asus-pat1,anonymous,2)
1416778024: Denied PUBLISH from mosqpub/6505-asus-pat1 (d0, q0, r0, m0, '/test', ... (4 bytes))
1416778024: Received DISCONNECT from mosqpub/6505-asus-pat1

[jpmens]

Glad to hear that, and thanks for reporting back.

[whidbey]

what?means when publish a message,you need to check the user again and again?
why dont' just auth functions,and when publish message no need auth any more?