Giter Site home page Giter Site logo

Comments (11)

jzaefferer avatar jzaefferer commented on July 18, 2024

This project depends on an old version of Grunt. Newer versions don't include the qunit-task anymore, and the new qunit-plugin actually bundles PhantomJS.

A PR to update to grunt 0.4.x and grunt-contribu-qunit would be very useful!

from jquery-simulate.

NiGhTTraX avatar NiGhTTraX commented on July 18, 2024

Updated grunt to 0.4.1 and refactored the Gruntfile locally, but I have a couple of questions before I send in the pull request:

  • The jshint target seems a bit complicated and unnecessary to me. The only thing it does is copy the keys from predefined to globals. Why not just edit the .jshintrc files to use globals in the first place and get rid of that function?
  • Since grunt helpers were deprecated, I just turned the git-date helper into a regular function. Is that ok?

from jquery-simulate.

scottgonzalez avatar scottgonzalez commented on July 18, 2024

The predefined/globals munging is because old versions didn't support reading the .jshintrc file and you had to use different syntax for node and .jshintrc. This should all be squashed into a signle task like in jquery/jquery-ui/@61d16ec939c11f63419cae5bc2aa990134f6c0ff (but the name should be all, not src).

The git-date change sounds fine.

Thanks.

from jquery-simulate.

NiGhTTraX avatar NiGhTTraX commented on July 18, 2024

Thanks for the reply.

Also, is the watch task still needed?

from jquery-simulate.

scottgonzalez avatar scottgonzalez commented on July 18, 2024

That'd be a question for @mikesherov. I never use watch tasks.

from jquery-simulate.

NiGhTTraX avatar NiGhTTraX commented on July 18, 2024

Pull request here: #18

I left the watch target there in case someone needs it.

from jquery-simulate.

mikesherov avatar mikesherov commented on July 18, 2024

Yeah, thanks for contributing! The watch task is no longer needed. Can you remove that too and then I can land this?

from jquery-simulate.

NiGhTTraX avatar NiGhTTraX commented on July 18, 2024

Sure thing. I created a var to hold the names of the files so I can pass them to the jshint and watch targets. Should I leave it like that or just squash them inside the jshint target?

from jquery-simulate.

scottgonzalez avatar scottgonzalez commented on July 18, 2024

I think either is fine.

from jquery-simulate.

NiGhTTraX avatar NiGhTTraX commented on July 18, 2024

Alright, left the var there so it's easier to change the filenames in the future. Squashed and pushed.

from jquery-simulate.

scottgonzalez avatar scottgonzalez commented on July 18, 2024

Thanks!

from jquery-simulate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.