Comments (11)
This project depends on an old version of Grunt. Newer versions don't include the qunit-task anymore, and the new qunit-plugin actually bundles PhantomJS.
A PR to update to grunt 0.4.x and grunt-contribu-qunit would be very useful!
from jquery-simulate.
Updated grunt to 0.4.1 and refactored the Gruntfile locally, but I have a couple of questions before I send in the pull request:
- The
jshint
target seems a bit complicated and unnecessary to me. The only thing it does is copy the keys frompredefined
toglobals
. Why not just edit the.jshintrc
files to use globals in the first place and get rid of that function? - Since grunt helpers were deprecated, I just turned the
git-date
helper into a regular function. Is that ok?
from jquery-simulate.
The predefined
/globals
munging is because old versions didn't support reading the .jshintrc
file and you had to use different syntax for node and .jshintrc
. This should all be squashed into a signle task like in jquery/jquery-ui/@61d16ec939c11f63419cae5bc2aa990134f6c0ff (but the name should be all
, not src
).
The git-date
change sounds fine.
Thanks.
from jquery-simulate.
Thanks for the reply.
Also, is the watch
task still needed?
from jquery-simulate.
That'd be a question for @mikesherov. I never use watch tasks.
from jquery-simulate.
Pull request here: #18
I left the watch
target there in case someone needs it.
from jquery-simulate.
Yeah, thanks for contributing! The watch task is no longer needed. Can you remove that too and then I can land this?
from jquery-simulate.
Sure thing. I created a var to hold the names of the files so I can pass them to the jshint
and watch
targets. Should I leave it like that or just squash them inside the jshint
target?
from jquery-simulate.
I think either is fine.
from jquery-simulate.
Alright, left the var there so it's easier to change the filenames in the future. Squashed and pushed.
from jquery-simulate.
Thanks!
from jquery-simulate.
Related Issues (20)
- Null relatedTarget in HtmlUnit
- Touch events are not supported HOT 4
- The event object is not passed to the handler HOT 1
- If statement at the top of dispatchEvent causes event params to not work HOT 1
- Shift + Drag not simulated correctly
- Tests for latest code ported from UI codebase
- fire mouse up at the ownerDocument instead of document
- Cannot simulate delegated events (e.g. click) HOT 8
- Error with HTTPs HOT 1
- Not Working on Firefox & IE HOT 3
- pointerdown and pointerup events in IE & edge
- drag and drop refer to document while they should refer to element HOT 3
- module is not defined
- Why not active development? HOT 3
- Simulating selecting an option in a <select> tag HOT 2
- Dropdown expansion does not work on Chrome Version 53.0.2785.101 (64-bit) HOT 1
- Can't install from npm HOT 2
- Not working on Chrome Version 56 HOT 2
- KeyEvent: 'which' property is not declared
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-simulate.