Comments (3)
I suppose markdown-mode can avoid this issue by calling call-process-region
directly or using start-process
(or start-file-process
) interfaces.
Use call-process-region directly
diff --git a/markdown-mode.el b/markdown-mode.el
index bad960d..59fcdfa 100644
--- a/markdown-mode.el
+++ b/markdown-mode.el
@@ -5270,8 +5270,15 @@ Return the name of the output buffer used."
output-buffer-name)))
;; Pass region to `markdown-command' via stdin
(t
- (shell-command-on-region begin-region end-region markdown-command
- output-buffer-name))))
+ (let ((buf (get-buffer-create output-buffer-name)))
+ (with-current-buffer buf
+ (setq buffer-read-only nil)
+ (erase-buffer))
+ (let ((ret (call-process-region begin-region end-region
+ shell-file-name nil buf nil
+ shell-command-switch markdown-command)))
+ (unless (zerop ret)
+ (error "Failed: '%s'" markdown-command)))))))
output-buffer-name))
(defun markdown-standalone (&optional output-buffer-name)
Using start-process
This is asynchronous execution.
diff --git a/markdown-mode.el b/markdown-mode.el
index bad960d..8573698 100644
--- a/markdown-mode.el
+++ b/markdown-mode.el
@@ -5270,8 +5270,16 @@ Return the name of the output buffer used."
output-buffer-name)))
;; Pass region to `markdown-command' via stdin
(t
- (shell-command-on-region begin-region end-region markdown-command
- output-buffer-name))))
+ (let ((buf (get-buffer-create output-buffer-name)))
+ (with-current-buffer buf
+ (setq buffer-read-only nil)
+ (erase-buffer))
+ (let ((input (buffer-substring-no-properties begin-region end-region))
+ (proc (start-process-shell-command "markdown" buf markdown-command)))
+ (set-process-sentinel proc #'ignore)
+ (set-process-query-on-exit-flag proc nil)
+ (process-send-string proc input)
+ (process-send-eof proc))))))
output-buffer-name))
(defun markdown-standalone (&optional output-buffer-name)
from markdown-mode.
I think the synchronous version is probably better. Minor modes like markdown-preview-mode
call the function and expect the result in the returned buffer for further processing, so asynchronous execution can lead to race conditions.
from markdown-mode.
Thanks for reporting this. I didn't realize this was happening. I merged #86. Thanks to @syohex for the patch. Please reopen if this does not fix the issue.
from markdown-mode.
Related Issues (20)
- Add support for LaTeX enviroments HOT 1
- Markdown mode leads to heavy input lag HOT 6
- [filelink](does not support spaces in filename) HOT 3
- Caret signs inside math are fontified as Markdown markup
- register yank-media-handler so we can paste images HOT 7
- Should filename links be URI-decoded? HOT 1
- Update MacPorts links in README
- tab in lists items results in invalid list indent itemization
- [Feature Suggestion] markdown-beginning/end-of-line functions
- `move-beginning-of-line` move to wrong position on heading when markdown-hide-markup is enabled HOT 1
- preserve indent-tabs-mode in markdown-edit-code-block HOT 5
- Incorrect table alignment with code block HOT 1
- Markdown hiding for links broken when text surrounded by square brackets
- resurrect emacs-26 support? HOT 2
- Bug: Angle-bracketed URLs in inline code are fontified as links
- "_" character in a variable name turns on underline HOT 1
- Wrong gfm-view-mode syntax highlight if only using *-ts-mode (tree-sitter modes) HOT 1
- v2.6 ERT test failures on wiki-link-rules and wiki-link-search-under-project with Emacs 29.1 HOT 4
- R language isn't included in markdown-gfm-recognized-languages HOT 3
- Wrong table width calculation for Unicode Combining Diacritical Marks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-mode.