Giter Site home page Giter Site logo

Comments (7)

hiradary avatar hiradary commented on July 28, 2024 2

@jrgarciadev Great! Thanks.

from react-iconly.

jrgarciadev avatar jrgarciadev commented on July 28, 2024 1

@hiradary Thanks for reporting, I'm going to review the icons map generator script https://github.com/jrgarciadev/react-iconly/blob/main/website/scripts/generate-icons.js

from react-iconly.

jrgarciadev avatar jrgarciadev commented on July 28, 2024

Hey @hiradary, it's listed with the Chevron Down name in the bold category.

Screen Shot 2020-12-29 at 18 07 32

One icon is extra because I added the "Heart" icon without inner line.
Screen Shot 2020-12-29 at 18 14 37

from react-iconly.

hiradary avatar hiradary commented on July 28, 2024

@jrgarciadev Got it!

There's one more thing to mention. We've got PaperFail and ShieldFail icons. It's mistakenly written as PaperFall in mapIcons.js file.

PaperFall: IconPack.PaperFall,

ShieldFall: IconPack.ShieldFall,

The correct form is used in the website:

"ShieldFail": ["shield", "fail", "insecure"],

"PaperFail": ["paper", "document", "file", "fail"],

from react-iconly.

jrgarciadev avatar jrgarciadev commented on July 28, 2024

Hi @hiradary thanks for reporting, I already rename it here -> fc70b86

from react-iconly.

hiradary avatar hiradary commented on July 28, 2024

@jrgarciadev I found another issue on the website...

if you visit here and select different sets such as two-tone and light, you'll see some sets contain less/more icons compared to the other ones. Whereas in the official pack, all sets contain 100 icons, nothing more or less. Here we should see 101 icons - considering the fact that you added another heart Icon.

from react-iconly.

jrgarciadev avatar jrgarciadev commented on July 28, 2024

Hi! @hiradary

The missing icons were solved, it was a problem with the names that did not allow the generate-icons.js script to generate them correctly, for example in website/icons/light there was the icon "TicketStart" with the name "Ticket Star.svg" with space.

Also, I updated these icons on Algolia

Here the changes -> 9a94cbf

from react-iconly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.