theme_foundation not working with ggplot2 v2.0.0

[jrnold]

theme_foundation not working with ggplot2 v2.0.0

[jrnold]

The issue seems to be that I changed how I created theme_foundation. Now it removes all colour and fill values from theme_gray. This means the the value of fill and colour for element_rect were NULL. I fixed this so the top level elements (rect, line, text) have colour = "black" and fill = "white") as before. It'll be a little bit before this is up on CRAN, but it is fixed in the github version.

devtools::install_github("jrnold/ggthemes")

[KJByron]

wow, thanks for taking care of so promptly

---

From: Jeffrey Arnold [email protected]
Sent: Tuesday, December 29, 2015 2:05 PM
To: jrnold/ggthemes
Cc: Karen J. Byron
Subject: Re: [ggthemes] theme_foundation not working with ggplot2 v2.0.0 (#56)

Closed #56#56 via 357303dhttps://github.com/jrnold/ggthemes/commit/357303d72a2de3508804b0b7c619e6bada6e4bcd.

[https://avatars3.githubusercontent.com/u/9687611?v=3&s=400]#56

theme_foundation not working with ggplot2 v2.0.0 · Issue #56 · jrnold/ggthemeshttps://github.com//issues/56
github.com
my old custom themes stopped working when I upgraded to ggplot2 v2.0.0, suspect the trouble is within theme_foundation here is a simple example: theme_cust <- function (base_size = 12, base_family...

Reply to this email directly or view it on GitHubhttps://github.com//issues/56#event-502432921.

[jrnold]

No problem. Thanks for finding the bug !