jrtibbetts/swiftdiscogs

A Swift client for the Discogs REST API.

swiftdiscogs's Issues

Fix authorized Discogs call failures in the simulator.

About a week ago, simulator calls to Discogs started failing with

Authorized GET for /oauth/identity; headers: ["User-Agent": "Mozilla/5.0; SwiftDiscogsApp (https://github.com/jrtibbetts/SwiftDiscogs)"]; params: [:]
"/oauth/identity" ["User-Agent": "Mozilla/5.0; SwiftDiscogsApp (https://github.com/jrtibbetts/SwiftDiscogs)"] [:]
2019-04-21 10:59:49.849680-0400 SwiftDiscogsApp[15261:3967886] CredStore - performQuery - Error copying matching creds.  Error=-25300, query={
    class = inet;
    "m_Limit" = "m_LimitAll";
    ptcl = htps;
    "r_Attributes" = 1;
    sdmn = "http://api.discogs.com";
    srvr = "api.discogs.com";
    sync = syna;
}
Couldn't sign in requestError[Error Domain=NSURLErrorDomain Code=401 "" UserInfo={OAuthSwiftError.response.data=<7b226d65 73736167 65223a20 22596f75 206d7573 74206175 7468656e 74696361 74652074 6f206163 63657373 20746869 73207265 736f7572 63652e22 7d>, Response-Headers={
    "Access-Control-Allow-Headers" = "Content-Type, authorization, User-Agent";
    "Access-Control-Allow-Methods" = "HEAD,OPTIONS,GET,OPTIONS";
    "Access-Control-Allow-Origin" = "*";
    "Access-Control-Expose-Headers" = Location;
    "Content-Length" = 61;
    "Content-Type" = "application/json";
    Date = "Sun, 21 Apr 2019 14:59:50 GMT";
    Server = "nginx/1.15.6";
    "Strict-Transport-Security" = "max-age=16000000";
    "Www-Authenticate" = "OAuth realm=\"http://api.discogs.com\"";
    "X-Content-Type-Options" = nosniff;
    "X-Discogs-Media-Type" = "discogs.v2";
    "X-Discogs-Ratelimit" = 60;
    "X-Discogs-Ratelimit-Remaining" = 58;
    "X-Discogs-Ratelimit-Used" = 2;
    "X-Frame-Options" = SAMEORIGIN;
    "X-XSS-Protection" = "1; mode=block";
}, NSErrorFailingURLKey=https://api.discogs.com/oauth/identity, NSLocalizedDescription=, Response-Body={"message": "You must authenticate to access this resource."}, OAuthSwiftError.response=<NSHTTPURLResponse: 0x600000339d20> { URL: https://api.discogs.com/oauth/identity } { Status Code: 401, Headers {
    "Access-Control-Allow-Headers" =     (
        "Content-Type, authorization, User-Agent"
    );
    "Access-Control-Allow-Methods" =     (
        "HEAD,OPTIONS,GET,OPTIONS"
    );
    "Access-Control-Allow-Origin" =     (
        "*"
    );
    "Access-Control-Expose-Headers" =     (
        Location
    );
    "Content-Length" =     (
        61
    );
    "Content-Type" =     (
        "application/json"
    );
    Date =     (
        "Sun, 21 Apr 2019 14:59:50 GMT"
    );
    Server =     (
        "nginx/1.15.6"
    );
    "Strict-Transport-Security" =     (
        "max-age=16000000"
    );
    "Www-Authenticate" =     (
        "OAuth realm=\"http://api.discogs.com\""
    );
    "X-Content-Type-Options" =     (
        nosniff
    );
    "X-Discogs-Media-Type" =     (
        "discogs.v2"
    );
    "X-Discogs-Ratelimit" =     (
        60
    );
    "X-Discogs-Ratelimit-Remaining" =     (
        58
    );
    "X-Discogs-Ratelimit-Used" =     (
        2
    );
    "X-Frame-Options" =     (
        SAMEORIGIN
    );
    "X-XSS-Protection" =     (
        "1; mode=block"
    );
} }}]

I looked into it briefly, but couldn't find any reason. It seems to have happened after I made the switch to specifying the Discogs secret key and ID in environment variables instead of in a plist, but I know that it did work for some time after that switch.

Show the Discogs login controller whenever an authenticated server call fails

Add Swift Package Manager support

Restore the master release view controller title

Add a collection view of artists

I had a placeholder in there, but it was causing runtime crashes for some unknown reason. I want to revisit this at some point.

Remove the release counts from artist search results

Discogs doesn't give me an easy way to retrieve these as quickly as I want to for the artist search results, so drop it. While I'm at it, add an image icon.

Add search scopes for all of Discogs & user's own collection

Right now, the search bar searches against all of Discogs.

Configure Travis-CI builds

It needs a travis.yml file to tell Travis to compile using Xcode 9.2.

Fix recently-broken unit tests

Update JSONClient dependency to 0.5.0

To take advantage of the OAuth1JSONClient superclass.

Factor out common UI stuff into a new framework

Things like the CollectionAndTableModel, etc.

Instead of going to the Discogs search results scene when tapping an iTunes library artist, pop up a disambiguation list

I should also keep track of which Discogs artist the user selected so that the disambiguation doesn't have to be displayed the next time.

Replace PromiseKit with Swift 5.5. async/await

Create the playback view

Hide the artists list search field when the view controller first appears

SwiftLint everything!

The right constraint of the CoverAndTableView is broken

This is most prominent in the MasterReleaseViewController.

Update to the latest PromiseKit

Import user's collection

Since there's no API for requesting a full collection database dump and then ingesting it, I think we just have to retrieve everything one page at a time.

Ok, switch back to using Swift Packages instead of git submodules and Carthage

Invalidates #48.

Switch to SwiftUI

May as well.

Display search results in the same view controller as the search field

Add a master release scene

Create a song data object

The Discogs API doesn't current have a song or track object, so create one. (The one in the Immediate project will probably work.)

Localize using SwiftGen

Get all user-facing strings ready for localization. Use SwiftGen to make it easy to use.

Regenerate the Discogs API keys and remove the environment file from git

Duh, Jason.

Fix some Codebeat warnings & errors

Update to the latest Xcode 12/Swift 5.3

Create a song view

And make it better than Spotify's or (🤮) iTunes.

Add a README file

Create the playback sources view

When playing (or about to play) a track, I want to select the media source.

All available media sources should be listed.
If a source requires an account, it should have a way to sign in and out of the service, and should show the user's current signed-in status.
Sources should be reorderable according to the user's preference.

Sort the artists list by the "Sort Artist" field

The sorting-related fields don't seem to be exposed on MPMediaItem. How can that information be accessed another way, short of doing a parallel search for the artists on MusicBrainz?

Add a license file

Parse embedded Discogs IDs in artist bio fields

I plan to subclass UILabel with a DiscogsLabel that finds Discogs references in plain text, converts all of it to attributed text, and adds a tap gesture for jumping to the referred-to scene.

Rename the master branch to main

Factor all Discogs server interactions into coordinators

Factor all Discogs client interactions into a coordinator class. (Coordinators aren't all bad, I guess.)

Find out why image URIs are always blank, even though the size fields are populated

Discussions on the Discogs API forums suggest that it's because the requests are unauthenticated, but I know that that's not the case.

Import Stylobate and Medi8 as git submodules

It's just so much easier than Carthage or trying to get Swift Package Manager to do what it's supposed to do.

Add a mock media library

The regular MPMediaQuery and other media classes aren't accessible when the app runs in the simulator or in unit tests, so create a mock one that can be used for those cases.