Comments (3)
The trick with the static private factory function (_of
) worx fine if there is a public and a private constructor, otherwise we can simply mark the constructor or the complete class as private in esdoc.
I have checked all files in src/format, src/chrono, src/zone, src/temporal, src/*. DONE
from js-joda.
With version v1.3.1 all private constructors, function and classes are removed from esdoc and marked as deprecated in the typescript definition.
Version v1.4.0 removes the private constructors, function and classes from the typescript definition. Typescript users might run in issues with this version. Typically a new instance in threeten are constructed by static factories, if you made it wrong and used a private constructors instead, replace it by a static factory. For the constructor of the DateTimeFormatterBuilder use the public variant with no arguments.
from js-joda.
I just remembered... we also need to change the .d.ts file after the changes to "remove" the protected/private constructors from the typescript bindings
from js-joda.
Related Issues (20)
- ZonedDateTime with Zulu or GMT0 timezone is unparsable from string? HOT 1
- Zoneless Date from Instant in Docs HOT 2
- No mention of Instant in manual - intended? HOT 1
- `DateTimeFormatter.ofPattern` not working as expected with "zone-offset" HOT 4
- Parsing Examples Broken HOT 2
- DateTimeFormatterBuilder.appendValue() 3 arguments: undefined must not be null HOT 3
- `SYSTEM` timezone formatting HOT 2
- apparent rounding error in parse HOT 5
- YearQuarter.now(): now.getYear is not a function HOT 1
- Duplicate identifier 'ISO_OFFSET_TIME'
- Missing Requirement of @js-joda/timezone should throw error or give some message HOT 2
- Why does ZoneId.systemDefault() return SYSTEM? HOT 2
- Leap year period calculation issue when start date = 29/02 HOT 5
- Issue with WeekField docs HOT 3
- DateTimeFormatter missing typescript type definitions for withLocale method
- Can't use LocalDate in redux store HOT 2
- Using English locale packages results in error "cldrData: unknown path main/en/ca-gregorian.json" HOT 3
- Duration.plusDuration seems to be missing from type definitions HOT 2
- Adding a formatter for Period/Duration HOT 1
- Mexico stopped using DST last year, but time.ZonedDateTime.now() is still shifting the time by one hour. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-joda.