Giter Site home page Giter Site logo

Comments (3)

pithu avatar pithu commented on May 19, 2024 1

The trick with the static private factory function (_of) worx fine if there is a public and a private constructor, otherwise we can simply mark the constructor or the complete class as private in esdoc.

I have checked all files in src/format, src/chrono, src/zone, src/temporal, src/*. DONE

from js-joda.

pithu avatar pithu commented on May 19, 2024 1

With version v1.3.1 all private constructors, function and classes are removed from esdoc and marked as deprecated in the typescript definition.

Version v1.4.0 removes the private constructors, function and classes from the typescript definition. Typescript users might run in issues with this version. Typically a new instance in threeten are constructed by static factories, if you made it wrong and used a private constructors instead, replace it by a static factory. For the constructor of the DateTimeFormatterBuilder use the public variant with no arguments.

from js-joda.

phueper avatar phueper commented on May 19, 2024

I just remembered... we also need to change the .d.ts file after the changes to "remove" the protected/private constructors from the typescript bindings

from js-joda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.