Comments (4)
I agree that if editorconfig is active then dtrt-indent should defer to it, but otherwise, it should work as normal: if the user doesn't want to use editorconfig, then dtrt-indent should do its job, and also it's not really dtrt-indent's place to notify the user about editorconfig (they may neither know nor care about it).
from dtrt-indent.
It's easy enough to detect whether editorconfig is installed and active, but how to detect whether there is a configuration for the current project? It seems to me that by dtrt-indent's philosophy, which is that it tries to guess the right thing to do, it should remain active if editorconfig is not run. It seems that editorconfig runs before the major mode hooks (it hooks into change-major-mode-after-body-hook
, which runs before the major mode hooks (where dtrt-indent-mode
is run), but editorconfig-apply
doesn't seem to set anything to say that it has run. (I'm also not sure whether dtrt-indent should run when editorconfig-apply
has run but unsuccessfully—probably not.)
from dtrt-indent.
but
editorconfig-apply
doesn't seem to set anything to say that it has run
How about if dtrt-indent-mode
simply ignore any settings that already have a buffer-local override? That should make it leave alone any relevant settings applied by editorconfig
and also other packages, such as prettier
. I suppose it would be a fairly major change at this point but I can't see how it would hurt.
from dtrt-indent.
@jscheid That seems reasonable.
from dtrt-indent.
Related Issues (20)
- 1/253 relevant lines HOT 5
- dtrt-indent-try-set-offset doesn't set generic indent variables HOT 1
- check adjacent-files like vim-sleuth HOT 2
- Advice is active regardless of whether the mode is active HOT 5
- Overriding tab setting for hard tabbed file HOT 11
- Issue with protobuf-mode HOT 3
- Delay for running dtrt-indent HOT 5
- Adapting tab mode to file content not working HOT 7
- Add guess-style to related work section of readme
- Support for different js-mode offset variables HOT 5
- How to install this? HOT 3
- Feature request: Infer additional variable in web-mode
- web-mode support doesn't work well for heterogeneous indent types HOT 4
- Improve analysis of files with consistent indentation where offset is guessed wrongly due to merging HOT 2
- Error while processing typescript files HOT 3
- Guess indentation for new files in a project HOT 3
- Support `typescript-ts-base-mode` and thus `tsx-ts-mode`? HOT 1
- Compilation warnings under Emacs 29.2 HOT 1
- `dtrt-indent-set` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dtrt-indent.