Comments (11)
I can accept pull-request for this behavior.
from node-jscs.
@mdevils I'll do it if you assign it to me ;-)
from node-jscs.
If you've got a good idea on implementing this, I would be glad to accept a pull-request ;-)
from node-jscs.
Actually, I think we could parse it more accurately and store result in Function* nodes. Is it possible?
Probably, using jsdoc3/jsdoc or OrgaChem/jsdoctypeparser or something else.
from node-jscs.
Not sure about storing in Function* nodes, but I'm totally agree that we need better JSDoc parsing approach.
Code at #75 looks messy, makes me unhappy to accept pull-request)). We need a good jsdoc parser with a good object-representation. With or without external libraries.
from node-jscs.
Okay, I'll to use some jsdoc parsers tonight. I think we should accept all kinds of jsdoc types? http://orgachem.github.io/jsdoctypeparser/
from node-jscs.
I'm not sure about type parsing. Do we need it?
from node-jscs.
I think it should be pretty useful to check it up as fast as possible. Afais lint-like tools pretty useful when they can check as much as they can to prevent buggy behaviour of software. Probably JSCS is not a place to check doctypes and type of resulting value but it's another question.
from node-jscs.
What's the verdict on this?
@mikesherov @zxqfox Should we deprecate this rule within jscs and inform users to use https://github.com/jscs-dev/jscs-jsdoc instead? I can create another issue for that task and put a PR together if you guys agree.
from node-jscs.
@mrjoelkemp probably yes. I've fixed this in plugin and I'm looking for issues.
from node-jscs.
yes, we should deprecate in 1.7, remove in 2.0
On Thu, Sep 18, 2014 at 11:37 PM, Alex Yaroshevich <[email protected]
wrote:
@mrjoelkemp https://github.com/mrjoelkemp probably yes. I've fixed this
in plugin and I'm looking for issues.Reply to this email directly or view it on GitHub
#59 (comment).
Mike Sherov
from node-jscs.
Related Issues (20)
- jscs exlucdeFiles not Work! HOT 1
- Should have exception for disallowSpacesInFunction for anonymous generators HOT 1
- not possible to include extensions with multiple "." characters HOT 7
- Error running rule requirePaddingNewLinesBeforeLineComments HOT 1
- not possible to ignore '.js' files with fileExtensions #2273
- Destructuring with default values in parameters throws an error. HOT 1
- Cannot find module 'babel-runtime/core-js/object/keys' HOT 8
- Error: Symbol is not defined (first character of file) HOT 3
- Add `templateStrings` as an option for the `allExcept` property of the `maximumLineLength` rule HOT 2
- requireSpaceBeforeDestructuredValues does not work in vanilla JS HOT 3
- maximumLineLength should optionally allow string literals to break the rule HOT 2
- validateIndentation should enforce endbrace at the same indentation as the line containing it's corresponding startbrace HOT 2
- Error running rule requireDollarBeforejQueryAssignment HOT 3
- JSCS goes into infinite loop HOT 2
- About jsx curly braces variable HOT 1
- JSCS crashes due to decorators HOT 1
- requireSpaceBetweenArguments doesn't work in constructor of es6. HOT 4
- How to write a rule which makes "case" align to "switch" in switch statement? HOT 1
- jscs.info offline HOT 3
- Disabling Specific Rules For a Single Line not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-jscs.