Giter Site home page Giter Site logo

Comments (11)

mdevils avatar mdevils commented on June 23, 2024

I can accept pull-request for this behavior.

from node-jscs.

qfox avatar qfox commented on June 23, 2024

@mdevils I'll do it if you assign it to me ;-)

from node-jscs.

mdevils avatar mdevils commented on June 23, 2024

If you've got a good idea on implementing this, I would be glad to accept a pull-request ;-)

from node-jscs.

qfox avatar qfox commented on June 23, 2024

Actually, I think we could parse it more accurately and store result in Function* nodes. Is it possible?
Probably, using jsdoc3/jsdoc or OrgaChem/jsdoctypeparser or something else.

from node-jscs.

mdevils avatar mdevils commented on June 23, 2024

Not sure about storing in Function* nodes, but I'm totally agree that we need better JSDoc parsing approach.

Code at #75 looks messy, makes me unhappy to accept pull-request)). We need a good jsdoc parser with a good object-representation. With or without external libraries.

from node-jscs.

qfox avatar qfox commented on June 23, 2024

Okay, I'll to use some jsdoc parsers tonight. I think we should accept all kinds of jsdoc types? http://orgachem.github.io/jsdoctypeparser/

from node-jscs.

mdevils avatar mdevils commented on June 23, 2024

I'm not sure about type parsing. Do we need it?

from node-jscs.

qfox avatar qfox commented on June 23, 2024

I think it should be pretty useful to check it up as fast as possible. Afais lint-like tools pretty useful when they can check as much as they can to prevent buggy behaviour of software. Probably JSCS is not a place to check doctypes and type of resulting value but it's another question.

from node-jscs.

mrjoelkemp avatar mrjoelkemp commented on June 23, 2024

What's the verdict on this?

@mikesherov @zxqfox Should we deprecate this rule within jscs and inform users to use https://github.com/jscs-dev/jscs-jsdoc instead? I can create another issue for that task and put a PR together if you guys agree.

from node-jscs.

qfox avatar qfox commented on June 23, 2024

@mrjoelkemp probably yes. I've fixed this in plugin and I'm looking for issues.

from node-jscs.

mikesherov avatar mikesherov commented on June 23, 2024

yes, we should deprecate in 1.7, remove in 2.0

On Thu, Sep 18, 2014 at 11:37 PM, Alex Yaroshevich <[email protected]

wrote:

@mrjoelkemp https://github.com/mrjoelkemp probably yes. I've fixed this
in plugin and I'm looking for issues.

Reply to this email directly or view it on GitHub
#59 (comment).

Mike Sherov

from node-jscs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.