Getters/setters and disallowSpacesInFunctionExpression problem

[jscs-dev]

Getters/setters and disallowSpacesInFunctionExpression problem

[mdevils]

Can you please explain, what exactly problem is?

[bdougherty]

The problem is that there isn't a space before the round brace, it's a space before the curly brace, which should be allowed by that rule. I'm running into this issue as well.

[hnrch02]

IT'S BRAD! Sorry, I just couldn't contain myself 😄 Anyhow, I'm also experiencing this problem. 👍

[tivac]

Also just ran into this

[BryanDonovan]

This should be reopened.. it's the one thing preventing me from using node-jscs I think.

[BryanDonovan]

I've added failing unit tests for this in this fork: https://github.com/BryanDonovan/node-jscs/compare/getter-setter-parens

.. but I haven't figured out a solution yet.

[BryanDonovan]

I've narrowed it down a bit.

This passes:

it('should not report missing space before round brace in getters w/o space inside curly braces', function() {
    checker.configure({ disallowSpacesInFunctionExpression: { beforeOpeningRoundBrace: true } });
    assert(checker.checkString('var x = { get foo() {} }').isEmpty());
});

But this fails:

it('should not report missing space before round brace in getters with space inside curly braces', function() {
    checker.configure({ disallowSpacesInFunctionExpression: { beforeOpeningRoundBrace: true } });
    assert(checker.checkString('var x = { get foo() { } }').isEmpty());
});

The error message points to the space after the closing round brace, before the opening curly brace.