bootstrap/bootstrap Update project name to match URL part

[jsdelivr]

bootstrap/bootstrap Update project name to match URL part

[jimaek]

@bebraw When you have some time can you check out this issue please?

[bebraw]

@jimaek Can someone else take a look?

[fulldecent]

Sorry in advance if this should be instead reported upstream to jsdelivr/api-sync

[jimaek]

@fulldecent No problem. It will take a bit longer to get fixed but it will be fixed. Sorry for that.

[tomByrer]

Isolated the issue:
api-sync reads the the folder in github.com/MaxCDN/bootstrap-cdn/tree/develop/public. For some odd reason, they called their bootstrap folder "twitter-bootstrap" which api-sync reads correctly, but their "bootstrap" alias is not read or is filtered out.

I got as far as finding out different ways to rename the folder, but it's time for bed & I'm working 50+ hours the next 6 days...

[tomByrer]

@jimaek I'm thinking this fix should go into v2, since people may be depending on current buggy behavior (unless there is a way to detect no one is). What do you think?

[jimaek]

Yes, v2 sounds like a good idea

[bebraw]

@tomByrer You could detect the symlinks and then duplicate the entries in API. That's a backwards compatible way to deal with it.

[tomByrer]

Duplicating entries is a good idea @bebraw for v1! (Though for v2 IMHO twitter-bootstrap should be dropped.)

Does this api require anything more than what's in package.json to run? I'd prefer to check my hacks :)

[bebraw]

Does this api require anything more than what's in package.json to run? I'd prefer to check my hacks :)

Nope. It should just work as is. You can override configuration if needed (either config.json or env).

[tomByrer]

@fulldecent if you can please test out the api-sync fix? It is easy, & I running left notes in the PR.

If you or someone else could test by running the API server locally, that would be awesome. .json looks fine & seems to lint. I won't have extra time until after I get headway after a front-end project or 2.

[fulldecent]

Got it running and this works great, thank you

On Fri, Sep 12, 2014 at 12:33 AM, tomByrer [email protected] wrote:

@fulldecent https://github.com/fulldecent if you can please test out
the api-sync fix jsdelivr/api-sync#14. It is
easy https://github.com/jsdelivr/api-sync#usage, & I running left notes
in the PR.

If you or someone else could test by running the API server locally, that
would be awesome. .json looks fine & seems to lint. I won't have extra time
until after I get headway after a front-end project or 2.

—
Reply to this email directly or view it on GitHub
#50 (comment).