Comments (8)
I think we can assume if sourceMappingURL\s*=
is present in a comment in a file we can consider it minified. The only file I can think of off the top of my head that will break this assumption is bootstrap.css
which has broken sourcemapping iirc
from bot.
sourceMappingURL\s*=
is a great idea! What should happen if there is:
var sourceMappingURL = somefile.js
? I'm thinking looking for a .map file is better.
Updated original post with test URL & Phase 2.
from bot.
thats why I said in a comment :)
from bot.
oops! Fixed top issue
from bot.
Lookin like a good start. @tomByrer I can give you pointers if you want to learn a bit of python and make a pr
from bot.
A branch of this issue is validating .map
files: validate .map
points to valid files; ensure x.map
is referenced by some file; Ensure that file is minified... etc
from bot.
Yep, removing comments before checking if minified is helpful
from bot.
I think 547c10b is a reasonable fix based on average line lengths. Essentially I assume if a file has an average line width of 200 characters we classify the file as minified
from bot.
Related Issues (20)
- Unable to update package because of case sensitivity? HOT 1
- Bot failes very often HOT 7
- Bot failing with SSL error HOT 1
- UTF-8 encoded files seems be interpreted as binary HOT 12
- Failed to warn about deleted files HOT 2
- Merge a pull request with squash option HOT 3
- Delete branch whenever a pull request is closed/merged
- Setup jsdelvr-bot for testing proposes on Heroku? HOT 4
- info.ini error where info.ini is present (again) HOT 2
- .html (on theme/github.html) seems odd to want to host
- info.ini error where info.ini is present (once again)
- Bot will sometime attempt to merge PRs too quickly HOT 3
- Folder structure changes reported incorrectly HOT 2
- Add an option to request re-check HOT 4
- Allow non-lowercase chars HOT 1
- bot says files have been modified HOT 1
- bot is not happy with minification
- Can't write the author's name properly due to non-ascii characters rule
- How to retain subdir within basePath
- Structure check way to strict HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.