ping has no raw output

[jsdelivr]

ping has no raw output

[zarianec]

This happens when you request too many packets from a slow target. We use -w 3 flag which sets the "global" command timeout to 3 seconds. In that case, ping will exit with a non-zero code, and probe:measurement:result message will not be emitted.

[jimaek]

Ok, then I guess we need to scale the global timeout based on packets? Maybe make it equal to packet count?
If we have 15 max packets then that means 15 max seconds.
Or set a static higher limit?
What do you think?

[zarianec]

Timeout equal to packets count will make it impossible to ping the high-latency targets even with a smaller amount of packets. In your example, ping with 1 packet will have a 1-second global timeout.
So, I vote for a static but higher timeout. 10-15 seconds?

But we still must think about handling command errors because a higher timeout will only mask the real issue.

[jimaek]

Yes, errors are important to be handled correctly, we have a separate issue about that.
Then lets set 15 seconds as new limit to fix this issue

[patrykcieszkowski]

Timeout equal to packets count will make it impossible to ping the high-latency targets even with a smaller amount of packets. In your example, ping with 1 packet will have a 1-second global timeout.

we can always use Math.max() and pick higher value

[jimaek]

But max of what values?

[patrykcieszkowski]

Match.max(3, packets).

It just picks the greater value.

3 - the old timeout
packets - timeout based on packets count, that you proposed

or make it 15s, just for good measure.

[jimaek]

Yeah Max wont help with slow servers, it would have to be some a lot more complex algorithm.
So I think the easiest fix is static 15s for now and then monitor and see if it needs something better than that

[patrykcieszkowski]

increased timeout to 15s.