Giter Site home page Giter Site logo

Comments (5)

patrykcieszkowski avatar patrykcieszkowski commented on May 29, 2024

By our GeoIP logic that means we should fallback to data by ipinfo https://ipinfo.io/208.85.17.142

according to our current logic, each field is selected individually

from globalping.

jimaek avatar jimaek commented on May 29, 2024

I think Artem had said he is not doing that. But in any case that won't work. It's all or nothing. With the exception of ASN and network that are outside of these DBs

from globalping.

patrykcieszkowski avatar patrykcieszkowski commented on May 29, 2024

Well, the code is.

https://github.com/jsdelivr/globalping/blob/master/src/lib/geoip/client.ts#L15

from globalping.

zarianec avatar zarianec commented on May 29, 2024

We select each field individually. I didn't expect that the difference could be on a country/continent level.

from globalping.

jimaek avatar jimaek commented on May 29, 2024

Ok then let's fix it and select them in groups without breaking the existing logic

from globalping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.