Work on req as well as res

[jshttp]

Work on req as well as res

[jonathanong]

meh not a big deal. ideally, it should only check for res. it may work for requests and req but i haven't tested that yet

[dougwilson]

Only accepting res is the only good way to do #4, which is why I ask. If you read the internal implementation of req and res, you'll see what I mean.

[dougwilson]

it may work for requests and req but i haven't tested that yet

it does work, because this modules does thingie.res, which translates to req.res, and thus works, weirdly.

[jonathanong]

hmmm i guess it doesn't then because you want to listen to finish on the req:

var req = http.request({
  method: 'POST',
  path: '/upload'
})

var stream = fs.createReadStream('filename')
stream.pipe(req)

finished(req, function () {
  stream.destroy()
})

[dougwilson]

Right. This module, as it is right now, only allows you to act when the response is finished. AFAIK this will also mean the request is finished, but I'm not sure. But you cannot actually pass in req, since it'll just add all the listeners on res anyway...

[dougwilson]

I first noticed this because I couldn't use finished with body-parser, since it wouldn't fire until after the response was finished, but I wanted something that would first after the req was finished.

Does it seem desirable that we wait for whatever is passed in to finish, instead of switching to an existing res property? This would mean koa cannot pass in the ctx variable directly, it would need to change to do ctx.res.

[jonathanong]

Does it seem desirable that we wait for whatever is passed in to finish, instead of switching to an existing res property?

ya

[dougwilson]

It looks like if this were changed, the koa example would become:

function* () {
  var stream = this.body = fs.createReadStream('thingie.json')
  onFinished(this.res, function (err) {
    stream.destroy()
  })
}

i.e. this -> this.res

[jonathanong]

yeah that's fine