Giter Site home page Giter Site logo

Comments (7)

fge avatar fge commented on June 15, 2024

This is indeed a bug; this test should be removed.

Or at least it should be modified so that this test passes.

from json-schema-test-suite.

Julian avatar Julian commented on June 15, 2024

Uh, yeah, I remember this -- I forgot if we got to a conclusion (obviously not if we didn't change the test back again) but I think you're right -- the draft 3 and draft 4 specs are very confusing, but they allow this (unfortunately). We need to fix it in draft 5 though, having URI references be valid is extremely surprising to people.

from json-schema-test-suite.

hasselmm avatar hasselmm commented on June 15, 2024

See http://tools.ietf.org/html/rfc3986#section-5.4.1 or just verify with any well tested library code, e.g. Qt's QUrl in strict parsing mode. The test is plain wrong.

from json-schema-test-suite.

Julian avatar Julian commented on June 15, 2024

I'm not sure what you're pointing out with that (that's not a relevant section) or what you mean by checking Qt. The spec is contradictory, we'll address it in draft 5. I'm not sure what to do about the test in the meantime, I have no issue either dropping or leaving it but we've flip flopped twice now, so I'm inclined to leave it given how long it's been in, until draft 5 is out.

from json-schema-test-suite.

sgpinkus avatar sgpinkus commented on June 15, 2024

👍 . So change to Absolute URI? This is not an "absolute URI" either -

"description": "a valid protocol-relative URI",
. That should be update too.

from json-schema-test-suite.

handrews avatar handrews commented on June 15, 2024

@casualjim Note: this was fixed in draft 5 by adding the "uriref" format and reserving "uri" for non-references only.

from json-schema-test-suite.

Julian avatar Julian commented on June 15, 2024

Closing this, should be addressed properly now in Draft 6

from json-schema-test-suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.