Comments (7)
This is indeed a bug; this test should be removed.
Or at least it should be modified so that this test passes.
from json-schema-test-suite.
Uh, yeah, I remember this -- I forgot if we got to a conclusion (obviously not if we didn't change the test back again) but I think you're right -- the draft 3 and draft 4 specs are very confusing, but they allow this (unfortunately). We need to fix it in draft 5 though, having URI references be valid is extremely surprising to people.
from json-schema-test-suite.
See http://tools.ietf.org/html/rfc3986#section-5.4.1 or just verify with any well tested library code, e.g. Qt's QUrl in strict parsing mode. The test is plain wrong.
from json-schema-test-suite.
I'm not sure what you're pointing out with that (that's not a relevant section) or what you mean by checking Qt. The spec is contradictory, we'll address it in draft 5. I'm not sure what to do about the test in the meantime, I have no issue either dropping or leaving it but we've flip flopped twice now, so I'm inclined to leave it given how long it's been in, until draft 5 is out.
from json-schema-test-suite.
👍 . So change to Absolute URI? This is not an "absolute URI" either -
. That should be update too.from json-schema-test-suite.
@casualjim Note: this was fixed in draft 5 by adding the "uriref" format and reserving "uri" for non-references only.
from json-schema-test-suite.
Closing this, should be addressed properly now in Draft 6
from json-schema-test-suite.
Related Issues (20)
- several misclassified tests using URNs in $id HOT 12
- doubts about ref.json test.
- Add a test for schema-items alongside "ignored" additionalItems HOT 3
- Tests for annotations HOT 7
- Tests for bundling HOT 28
- draft2019-09 output-schema.json is wrong HOT 3
- Revamped output testing HOT 8
- test: unevaluatedItems with nested items > with invalid additional item HOT 3
- Incorrect Revert "by default, "format" only annotates, not validates"? HOT 5
- Negative schema tests HOT 4
- File URIs with pointer fragments HOT 6
- New release? HOT 4
- Perhaps add test for `"type": []` HOT 3
- Suite contains invalid, positive tests for idn-hostname HOT 2
- Add tests for single label IDN hostnames
- Missing test for `unevaluatedProperties` and `$dynamicRef` HOT 1
- Add an `id` property to all test cases HOT 4
- Add a `specification` property to test cases + tests HOT 12
- Should identifier declarations be respected in non-schema locations? HOT 29
- Clarify how test runners should handle `format`. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-schema-test-suite.