Giter Site home page Giter Site logo

Comments (2)

jstrieb avatar jstrieb commented on May 10, 2024

Hi @Cielain, Thanks for taking the time to raise this issue!

Even though this has not been implemented yet, I absolutely acknowledge that displaying the password in plaintext can be a bit inconvenient. It is a long-term feature I have considered adding, but I will bump it up since you have expressed interest. I'm currently finishing my final semester, so I expect to take a look at issues in my personal projects sometime over the summer.

In the meantime, the brief background on why I chose to do it this way initially is that it was easier, and avoided a potential security problem. It was easier because I wouldn't have to make an additional page for entering the password (this would admittedly be similar to the page to lock a link, but I was hustling to get it to a stage where I was comfortable releasing it), and then the feature fell to the back-burner. Regarding security: since users can enter hints, I was concerned about displaying them in a way that might accidentally lead to a cross-site scripting vulnerability, and using the JavaScript window.prompt avoided this.

That being said, you're right that it has the potential to introduce a practical security risk when someone might be looking over your shoulder! I'll look into taking care of this eventually, and in the meantime will leave the issue open.

Almost forgot: if you're still concerned, in the meantime, you can use the "decrypt page" here:
https://jstrieb.github.io/link-lock/decrypt/

This page doesn't do the automatic redirect, but it does use a proper password field.

Thanks again for your interest in this project!

from link-lock.

jstrieb avatar jstrieb commented on May 10, 2024

It's been a little less than two years, but I finally got around to this!

All links that have been created will no longer prompt the user to enter a cleartext password.

from link-lock.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.