Giter Site home page Giter Site logo

Comments (10)

whernebrink avatar whernebrink commented on June 11, 2024 1

@NetanelBasal How should this be done? Is it just an nx migration that needs to be ran? I could try helping out, but would be great with some pointers. We really would like to migrate and try angular 17 for our application and transloco is the only thing that is preventing us right now. :)

from transloco.

beloveddd avatar beloveddd commented on June 11, 2024 1

I have the same issue with Transloco and Angular 17 :(

from transloco.

hernebrink avatar hernebrink commented on June 11, 2024 1

@shaharkazaz, thanks for getting back to this. Indeed it works! Not sure why we experienced an issue with our upgrade. I've tested with 6.0.1 and it works. Thanks. :)

from transloco.

alexdabast avatar alexdabast commented on June 11, 2024 1

I don't know then if my PR is still required @shaharkazaz. I guess it would be nice to have the repo updated to the latest version. I have push all the changes that you asked for the PR btw

from transloco.

alexdabast avatar alexdabast commented on June 11, 2024

@whernebrink
What is the error when you want to use it with angular 17 ?
if it is only the version issue when you try to npm i ?
Then my first guess is that this repo just need to run a angular 17 migration
This will basically bump all angular version to 17 in all package.json file
https://github.com/ngneat/transloco/blob/ab57b376ba11cfa380405fe0fc88a2751f0184cd/libs/transloco/package.json#L43

from transloco.

alexdabast avatar alexdabast commented on June 11, 2024

I just created a brand new angular 17 app installed @ngneat/transloco and it works fine
So what's the issue @beloveddd and @whernebrink
image

from transloco.

shaharkazaz avatar shaharkazaz commented on June 11, 2024

@alexdabast Thank you for asking the exact question I wanted to ask and for the PR 🙂
What is the issue here? Transloco works with Angular 17.

from transloco.

shaharkazaz avatar shaharkazaz commented on June 11, 2024

@whernebrink can you share what was the issue you faced?

from transloco.

hernebrink avatar hernebrink commented on June 11, 2024

@shaharkazaz, unfortunately not. I was filing the issue on behalf of a team mate who was the one trying. Probably not a "real" issue I suppose. Node version, old node_module, or other local thing. Sorry for not having a better answer.

from transloco.

theguidingstar avatar theguidingstar commented on June 11, 2024

I am getting this error after migration to Angular 17 @alexdabast
Anything I'm doing wrong here??

node_modules/@ngneat/transloco/lib/transloco.providers.d.ts:23:21 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@angular/core")' call instead.

23     provide: import("@angular/core").InjectionToken<Content>;
                       ~~~~~~~~~~~~~~~

node_modules/@ngneat/transloco/lib/transloco.service.d.ts:1:27 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@angular/core")' call instead.

1 import { OnDestroy } from '@angular/core';
                            ~~~~~~~~~~~~~~~

node_modules/@ngneat/transloco/lib/transloco.service.d.ts:10:21 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@angular/core")' call instead.

10 import * as i0 from "@angular/core";

from transloco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.