Create init.d script to start pochta

[ctapobep]

Create init.d script to start pochta

[jk1]

Done

[ctapobep]

• The script should create a PID file when starting in order to finish pochta correctly during stop.
• Also, CentOS uses chkconfig utility for services, current file cannot be understood by this utility

Could you please also add a restart command that runs stop && start afterwards?

[jk1]

Currently it can perform stop without any pid-files. Why do we need to create one?

[ctapobep]

Because it's fragile (won't work if there are several PIDs with 'pochta' in its name, this includes su pochta) & risky (can potentially kill wrong pids).

[jk1]

This makes sense. Script has been updated to user pid. I'm not quite sure that ~/.pochta/pid is the best place for pid-file, but at least we have no permission problems there. Suggestions are most welcomed, as usual.

[masyan]

/var/run/pochta to PID file, and set permissions to dir (/var/run/pochta)

[jk1]

changed pid location to /var/run/pochta

[ctapobep]

There is still no chkconfig support. It requires a line like chkconfig: - 85 15. Also, in a guide there are no installation instructions for chkconfig.

[ctapobep]

Several notes:

• PID is created even if service failed to start
• After start, the script should finish (right now it waits for ctrl+c which doesn't allow running it from CI)
• If we don't have permissions to write into /var/run, a respective error should be shown and we should terminate the startup.
• Would be useful to log into .jtalks or into /var/logs/pochta folders

[jk1]

PID is created even if service failed to start
After start, the script should finish (right now it waits for ctrl+c which doesn't allow running it from CI)
If we don't have permissions to write into /var/run, a respective error should be shown and we should terminate the startup.

fixed

Would be useful to log into .jtalks or into /var/logs/pochta folders

Application level logging will be implemented soon, so I see no reason to address logging issues in scope of the service script

[ctapobep]

I tried the latest version of script, there appears to be an issue with restarting. Server doesn't catch up with the script, so when new instance of Pochta starts, the previous instance is still listening on the port:

[pochta@dev ~]$ service pochta restart
Stopping Pochta service...
Service stopped
Starting Pochta service...
Exception in thread "main" java.lang.ExceptionInInitializerError
    at org.jtalks.pochta.PochtaPackage-main-cba84353.main(main.kt:15)
    at org.jtalks.pochta.PochtaPackage.main(main.kt:1)
Caused by: java.net.BindException: Address already in use
    at sun.nio.ch.Net.bind0(Native Method)
    at sun.nio.ch.Net.bind(Net.java:444)
    at sun.nio.ch.Net.bind(Net.java:436)
    at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
    at sun.net.httpserver.ServerImpl.bind(ServerImpl.java:133)
    at sun.net.httpserver.HttpServerImpl.bind(HttpServerImpl.java:54)
    at org.jtalks.pochta.http.HttpServer.<init>(HttpServer.kt:25)
    at org.jtalks.pochta.http.HttpServer.<clinit>(HttpServer.kt)
    ... 2 more

Also, note that this doesn't return error code:

[pochta@dev ~]$ echo $?
0

[jk1]

It seems to be an application issue with TCP ports not being released properly. Please recheck it, now it should be fine.