Does not work with "null" root.

[GoogleCodeExporter]

Does not work with "null" root.

[GoogleCodeExporter]

Hmm, this initially seems to be a perforce problem proper instead of a plugin 
problem. Running the commands locally shows that:


C:\work\niftyplugins>p4.exe  -p quad:1666 -u Jim_Tilander -c QUAD edit 
"c:\work\perforce\Shared\AuroraTest\Listener.cpp"
c:\work\perforce\Shared\AuroraTest\Listener.cpp - file(s) not on client.

C:\work\niftyplugins>p4.exe -p quad:1666 -u Jim_Tilander -c QUAD edit 
"c:\work\perforce\Shared\AuroraTest\Listener.cpp"
c:\work\perforce\Shared\AuroraTest\Listener.cpp - file(s) not on client.

C:\work\niftyplugins>p4 client  quad -o
Usage: client -o [ -t template ] clientname
Unexpected arguments.

C:\work\niftyplugins>p4 client  -o quad
# A Perforce Client Specification.
#
#  Client:      The client name.
#  Update:      The date this specification was last modified.
#  Access:      The date this client was last used in any way.
#  Owner:       The user who created this client.
#  Host:        If set, restricts access to the named host.
#  Description: A short description of the client (optional).
#  Root:        The base directory of the client workspace.
#  AltRoots:    Up to two alternate client workspace roots.
#  Options:     Client options:
#                      [no]allwrite [no]clobber [no]compress
#                      [un]locked [no]modtime [no]rmdir
#  SubmitOptions:
#                      submitunchanged/submitunchanged+reopen
#                      revertunchanged/revertunchanged+reopen
#                      leaveunchanged/leaveunchanged+reopen
#  LineEnd:     Text file line endings on client: local/unix/mac/win/share.
#  View:        Lines to map depot files into the client workspace.
#
# Use 'p4 help client' to see more about client views and options.

Client: QUAD

Update: 2009/06/22 20:50:52

Access: 2009/06/22 20:50:57

Owner:  Jim_Tilander

Host:   quad

Description:
        Created by Jim_Tilander.

Root:   null

Options:        noallwrite noclobber nocompress unlocked nomodtime rmdir

SubmitOptions:  submitunchanged

LineEnd:        local

View:
        //depot/main/... //QUAD/c:/work/perforce...


C:\work\niftyplugins>dir "c:\work\perforce\Shared\AuroraTest\Listener.cpp"
 Volume in drive C is WindowsXP
 Volume Serial Number is 38BF-93DF

 Directory of c:\work\perforce\Shared\AuroraTest

04/23/2009  09:36 PM             1,188 Listener.cpp
               1 File(s)          1,188 bytes
               0 Dir(s)  190,061,101,056 bytes free

Original comment by [email protected] on 23 Jun 2009 at 3:59

• Changed state: Accepted

[GoogleCodeExporter]

Hm, so I made a type in the clientspec above, fixing the view to read:

//depot/main/... //QUAD/c:/work/perforce/... 

instead caused the whole thing to work now.... Funny enough, the incorrect 
version 
still worked for the p4win app, but not the command line.

Original comment by [email protected] on 23 Jun 2009 at 4:10

[GoogleCodeExporter]

Original comment by [email protected] on 23 Jun 2009 at 4:12

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Seems to work just fine, although it has potential for foul ups ... but nothing 
really 
to do with the plugin, more of an issue with the underlying perforce 
environment.

Original comment by [email protected] on 8 Jul 2009 at 4:22

• Changed state: Invalid

[GoogleCodeExporter]

I believe it's linked to the fact that when you have a null root the drive is 
always considered to be lower case for Perforce this should work in all 
situations (null root or not ):

public static bool EditFile(OutputWindowPane output, string filename)
            {
                StringBuilder sb = new StringBuilder(filename);
                if (Path.IsPathRooted(filename) && sb.Length > 1 && sb[1] == ':' && Char.ToLower(sb[0]) != sb[0])
                {
                    sb[0] = Char.ToLower(sb[0]);
                }
                return Internal_CheckEditFile(new CheckoutCallback(Internal_EditFile), output, sb.ToString());
            }

Original comment by [email protected] on 19 Apr 2013 at 3:39