Comments (2)
This appears to be more serious than I previously thought. It's not specific to ValueTuple keys. Instead, it appears to be any time there is more than 1 and less than 8 items in the dictionary, the lookup fails.
from collections.pooled.
The cause of this bug was an optimization I put into Resize: In this scenario, we're going from a capacity of 3 to a capacity of 7, but the underlying array we got from the ArrayPool is actually a 16-element array. In an attempt to short-circuit the "allocate new array, copy everything, and sort the entries into the new set of buckets" code, I failed to do the "sort the entries into the new set of buckets" part.
Revised code skips over the "allocate new arrays and copy everything" part when the underlying array is large enough for the new capacity, but it now correctly sorts the entries into the new set of buckets, so lookups succeed when they should.
from collections.pooled.
Related Issues (20)
- new PooledList<PlayerState>(Players.Count, preallocate : true) HOT 8
- PooledList.Dispose semantics HOT 6
- Support for .NET Standard 2.1 HOT 15
- Disposing PooledDictionary doesn't dispose PooledList stored as values HOT 2
- Support for ObservableCollection HOT 6
- GC of boxing if key is struct HOT 1
- Aggressive optimization and inlining foor PooledList.Span HOT 5
- Retrieve Memory<T> from PooledList<T>
- Nested pooled collections crash the Visual Studio heap snapshot
- Resurrect rented buffers or arrays in finalyzer HOT 1
- Pooled Lookup
- Pooled Array
- PooledSet is generating GC when item gets removed HOT 1
- Add equivalent of CollectionsMarshal.GetValueRef for PooledDictionary.
- Why not implents INotifyCollectionChanged or provide a BindingVersion
- linq benefits from pooled? HOT 1
- Consider PooledSortedList
- Is the repos alive?
- How about call GC.SuppressFinalize(this) to prevent add to finalization queue.
- PooledDictionary.Remove with Count 0 = Exception HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collections.pooled.