Not used `string_traits::subject_type`

[01e9]

Not used `string_traits::subject_type`

[jtv]

Actually, you were right. In this instance (and one other) it could be completely removed. After a decade or so writing a codebase like this, it becomes hard to see these things. :-)

[jtv]

It's a good point... It's not actually part of the traits API, but it does factor out some repetition of the type, which may help maintenance, and helps hide uninteresting differences between the specialisations.

What if I just made subject_type private?

[01e9]

it does factor out some repetition of the type, which may help maintenance, and helps hide uninteresting differences between the specialisations.

I know that type aliases are handy in templates, but I did not get this point, especially if that alias is not used anywhere (at least in headers).

What if I just made subject_type private?

It will be removed from the focus. I am ok with this solution.