Comments (2)
I just checked some of the pylint default warnings and got some questions:
How should we treat API changes?
For example: Nyaa.get
and SukebeiNyaa.get
have an inconsistently named parameter called id
(or view_id
in Nyaa.get
). If we renamed that to view_id
, which would be more specific, code like sukebei_nyaa.get(id="123")
would break.
How should we handle the integration/automation of pylint?
The simplest thing would be running it manually; this is already possible.
We could also include it in a Pre-commit hook or run it from the CI. While the last option might be harder to set up, it could be interesting, depending on the number of automated tests planned.
We already talked about Pantsu; remove it from the project?
I don't want to investigate warnings in places that will be deleted anyway.
from nyaapy.
I'll take this, and I'm gonna think about how we can deal with this. At this moment I have some fixes on my local branches, but it needs some design changes.
from nyaapy.
Related Issues (20)
- Add support for sukebei (Nyaa.si and NyaaPantsu) HOT 3
- Improve the torrent objects HOT 1
- Remakes, trusted and those things
- Add NyaaPantsu news HOT 1
- Request module not found
- Search torrents by user
- PEP8 optimization HOT 1
- Error on code ```Utils.py``` HOT 2
- Write some tests HOT 1
- Refactor "utils" module to not use a class HOT 1
- Replace BeautifulSoup by lxml HOT 10
- [Nyaa.si][last_uploaded_torrents] How about using RSS? HOT 6
- Update Pantsu data HOT 2
- No filter documentation HOT 1
- No matching distribution found for nyaapy==0.6.2 HOT 7
- Confusion HOT 4
- A way to convert Torrent object into dictionary HOT 1
- Python 3.10 support
- Exception when the response contains emojis - HOT 1
- Make the whole code async HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nyaapy.