Giter Site home page Giter Site logo

Add Pylint about nyaapy HOT 2 OPEN

juanjosalvador avatar juanjosalvador commented on July 16, 2024
Add Pylint

from nyaapy.

Comments (2)

Euklios avatar Euklios commented on July 16, 2024

I just checked some of the pylint default warnings and got some questions:

How should we treat API changes?
For example: Nyaa.get and SukebeiNyaa.get have an inconsistently named parameter called id (or view_id in Nyaa.get). If we renamed that to view_id, which would be more specific, code like sukebei_nyaa.get(id="123") would break.

How should we handle the integration/automation of pylint?
The simplest thing would be running it manually; this is already possible.
We could also include it in a Pre-commit hook or run it from the CI. While the last option might be harder to set up, it could be interesting, depending on the number of automated tests planned.

We already talked about Pantsu; remove it from the project?
I don't want to investigate warnings in places that will be deleted anyway.

from nyaapy.

JuanjoSalvador avatar JuanjoSalvador commented on July 16, 2024

I'll take this, and I'm gonna think about how we can deal with this. At this moment I have some fixes on my local branches, but it needs some design changes.

from nyaapy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.