Giter Site home page Giter Site logo

Comments (7)

huahaiy avatar huahaiy commented on August 26, 2024

Thank you very much for including Datahike in the benchmark and reporting this performance issue with Windows. I would appreciate if you could update your reddit post to include your Ubuntu run numbers also. More data points help everyone. I will investigate the problem when I get hold of a Windows machine.

from datalevin.

joinr avatar joinr commented on August 26, 2024

No problem. Updated in reddit thread and on the datalevinbench repo README.

from datalevin.

huahaiy avatar huahaiy commented on August 26, 2024

Thank you. @joinr I appreciate it.

from datalevin.

huahaiy avatar huahaiy commented on August 26, 2024

It may not be a performance issue. Please take a look at joinr/datalevinbench#2

from datalevin.

joinr avatar joinr commented on August 26, 2024

That was it indeed. The assumption about the temp file directory, /tmp, doesn't hold on Windows. This led to an ever growing database. The interesting news is that a db about 13x the size was still reading about 3x slower than the datascript. With a fresh db, the results conform to your reported baseline. No problem with lmdb on windows, just tempfile expectations :)

I added new-db to the benchmark to delete the old db (similar to what datahike is doing), which technically adds a little to the measurements, but the results are apparently identical (e.g. deletion isn't a problem). The "real" fix would be to implement a portable temp file pathway for the db (I think the storage/open function called with nil directory creates a tmp/uuid file, so that would probably be the only place to define a wrapper that leverages (System/getProperty "java.io.tmpdir") to construct a portable temp directory.

from datalevin.

joinr avatar joinr commented on August 26, 2024

Updated reddit thread and readme for posterity.

from datalevin.

huahaiy avatar huahaiy commented on August 26, 2024

Great. Thanks!

from datalevin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.