Comments (5)
@baumgold - it is not the type of the numbers you use but the actual value. If your values were not actually all integers things would work:
julia> df = DataFrame(A = [FixedDecimal{Int,3}(1), FixedDecimal{Int,3}(2), FixedDecimal{Int,3}(3.1)])
3×1 DataFrame
Row │ A
│ FixedDec…
─────┼───────────
1 │ 1.0
2 │ 2.0
3 │ 3.1
julia> unique(df)
3×1 DataFrame
Row │ A
│ FixedDec…
─────┼───────────
1 │ 1.0
2 │ 2.0
3 │ 3.1
Note that BigInt
works:
julia> BigInt(FixedDecimal{Int,3}(1))
1
It is just the shorthand big
does not work (which could be added to that package but probably its maintainers should make this decision).
@nalimilan - probably we can change big
to BigInt
in DataFrames.jl as a solution. OK?
@baumgold - as a temporary fix you can define big(x::FixedDecimal) = BigInt(x)
in your code. It should not break anything (as big
is not supported by FixedDecimal
).
from dataframes.jl.
@nalimilan - we need to make a decision here. FixedPointDecimals.jl does not support conversion of integer FixedDecimal
values to BigInt
. I think it should, but the fact is that it does not. Our code assumes that all integers can be passed to big
and be properly converted to BigInt
. Do you think we should change this assumption?
@baumgold - the simplest fix would be on FixedPointDecimals.jl side if they added support for conversion of integer values to BigInt
.
from dataframes.jl.
@bkamins - thanks for the quick response. I would be happy with a fix on the FixedPointDecimals.jl side. I'm not familiar enough with the purpose of Base.big
to know how that should be implemented for FixedDecimal
. You say that it should support conversion to BigInt
but FixedDecimal
is more akin like a non-lossy BigFloat
than a BigInt
. How should we proceed? Thanks for your help.
from dataframes.jl.
It looks like the following may be the correct implementation but I'm not confident. Thoughts?
julia> Base.big(n::FixedDecimal) = convert(BigFloat, n)
julia> Base.big(::Type{<:FixedDecimal}) = BigFloat
from dataframes.jl.
I logged JuliaMath/FixedPointDecimals.jl#91 to request that Base.big
be implemented for FixedDecimal.
from dataframes.jl.
Related Issues (20)
- `describe` is slow HOT 3
- CartesianIndex error in Julia 1.11 HOT 4
- `DataFrame(x=Int[], y=Int)` HOT 3
- Add comparison function for dataframes which can handle both isapprox and isequal column types HOT 2
- mapcols! should modify the parent of a SubDataFrame HOT 11
- Feature request: Pairs in stack HOT 2
- Grouped DataFrame with array elements fails to combine HOT 4
- error when combining a grouped empty dataframe using `first` HOT 6
- Short circuit && on subset? HOT 1
- Integer strings as colnames/selectors are error prone HOT 2
- Suggestion - Matrix Syntax for hcat (as well as vcat) HOT 4
- Document custom generation of column names in manual HOT 9
- `join` should not introduce `Missing` types to schema HOT 1
- Consider removing Tables.allocatecolumn in vcat
- DataFrame(t::Table) converts PooledVector columns HOT 2
- Sampling GroupedDataFrames (rand) HOT 5
- Julia 1.12.0-DEV: testing DataFrames throws a 'method dispatch ambiguities' error HOT 2
- Add options to `join` missing error? HOT 1
- Column types seem to change after inner-join between two DataFrames HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dataframes.jl.