Giter Site home page Giter Site logo

Comments (3)

mcabbott avatar mcabbott commented on August 16, 2024

For testing purposes, would it be sufficient to overload instead? That would avoid hash complications, and maybe invalidations.

Like here:
https://github.com/JuliaDiff/Diffractor.jl/pull/73/files#diff-fba4d4a7c64aacd9b1a662bca4487f3e849b43f09e65f6c8788a3f142b989f65R27-R32

from chainrulescore.jl.

oxinabox avatar oxinabox commented on August 16, 2024

I want to test exact equality, though, not approximate.
And I want equality on tuples to work.
(isapprox isn't defined for tuples)

The hash complication is trivially resolved.
I hope there are not major invalidation issues, especially if we restrict it to Number. (or perhaps Union{Number,Array})
We did have to remove it from thunks, but that was unrestricted:
#524

from chainrulescore.jl.

oxinabox avatar oxinabox commented on August 16, 2024

Not having this is causing issues for Diffractor
I look into this further soon and see what (if any) invalidation issues there are.

from chainrulescore.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.