Giter Site home page Giter Site logo

Comments (7)

vchuravy avatar vchuravy commented on May 24, 2024 1

The other option would be to implement QR decomposition ourselves (there are some fun research papers on that topic.)

from cuarrays.jl.

MikeInnes avatar MikeInnes commented on May 24, 2024

If it's in CUBLAS then it should be pretty easy to wrap (I don't know if it is though).

If not there may be a third-party library we can borrow; or it may not be too difficult to write a custom kernel to do it.

from cuarrays.jl.

MikeInnes avatar MikeInnes commented on May 24, 2024

Ok, these are actually a part of cuSOLVER. We have wrappers for that here, but they are pretty stale.

It would be very useful to update CUSOLVER.jl, and perhaps move the wrappers into CuArrays as we did with CUBLAS.

from cuarrays.jl.

jdnz avatar jdnz commented on May 24, 2024

Hi Mike,
Thanks for integrating cuSolver into this package. I was looking at it and trying to also add the function orgqr that takes the output from geqrf and returns the Q matrix from the QR decomposition (see #36). This works fine when the matrix A from qeqrf has size(A, 2) < size(A, 1), but in the reverse case we need to slice the matrix Q = A[:, 1:size(A, 1)]. This gives an error when you have CuArrays.allowscalar(false) as you do in the test file. Does that mean that such a slice is suboptimal? Is there some other way to do it? This also applies to making the ormqr code more general, i.e. to work when size(A, 2) != size(A, 1).

from cuarrays.jl.

MikeInnes avatar MikeInnes commented on May 24, 2024

Slicing like that should be fine – it works with xs = cu(rand(5,5)); xs[:, 1:5] for example. Is that definitely what's causing the issue?

from cuarrays.jl.

jdnz avatar jdnz commented on May 24, 2024

Ah yeah sorry, I just realized it was caused by an actual scalar index call. I've replaced it now, so it should work correctly.

from cuarrays.jl.

andreasnoack avatar andreasnoack commented on May 24, 2024

I think this can be closed

from cuarrays.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.