Giter Site home page Giter Site logo

Comments (5)

nicoguaro avatar nicoguaro commented on June 1, 2024 1

I am not thinking as a user in this context but as a contributor. In that case, it is common practice to run tests locally before doing a PR. I would guess that's the public intended for that information.

from mechkit.

JulianKarlBauer avatar JulianKarlBauer commented on June 1, 2024

Hi nicoguaro,
thank you for pointing this out. So far, this is intended behavior.
Why do you expect that installing in "develop"-mode would install pytest?

If I do python setup.py develop on the source code of continuum_mechanics, test requirements are also not met, which from my personal point of view is fine.

If you point me towards an example where installing in develop mode is used to install test requirements, I rethink whether this is to be considered as a feature.

from mechkit.

JulianKarlBauer avatar JulianKarlBauer commented on June 1, 2024

Another thought: The tests are run by Github-CI before pushing to PyPI. I don't think any user will run the tests. If so, instructions on running the tests are found in .github/workflow/... files. I think this procedure is quite common.

from mechkit.

JulianKarlBauer avatar JulianKarlBauer commented on June 1, 2024

Thank you so much for reminding me on the contributor instructions on tests. Now I realize the problem. I added a note on installing pytest before running the tests. Are you fine with this solution? Please see #47 for a proposal.

from mechkit.

nicoguaro avatar nicoguaro commented on June 1, 2024

Thank you so much for reminding me on the contributor instructions on tests. Now I realize the problem. I added a note on installing pytest before running the tests. Are you fine with this solution? Please see #47 for a proposal.

It looks OK to me.

from mechkit.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.