Giter Site home page Giter Site logo

Comments (8)

gcamilo avatar gcamilo commented on July 21, 2024

@amitmurthy

from clustermanagers.jl.

amitmurthy avatar amitmurthy commented on July 21, 2024

Wouldn't it be better to use -v and specify only the env variables you need? params contains all the keyword args. You could pass a qsubenv = Dict("ENV1"=>"VAL1",....) and process them as -v options.

from clustermanagers.jl.

gcamilo avatar gcamilo commented on July 21, 2024

So adding another argument to addprocs where you can optionally choose which environment variables to pass?

from clustermanagers.jl.

amitmurthy avatar amitmurthy commented on July 21, 2024

Yes. All keyword arguments to addprocs are available in params in
launch(manager::Union{PBSManager, SGEManager}, params::Dict, ..........)

from clustermanagers.jl.

gcamilo avatar gcamilo commented on July 21, 2024

So I thought of modify addprocs_sge definition:

addprocs_sge(np::Integer, queue::AbstractString="",enviromentVars::AbstractString="") = addprocs(SGEManager(np, queue),(:enviromentVars,enviromentVars))

And then modifying launch to have:

function launch(manager::Union{PBSManager, SGEManager}, params::Dict, instances_arr::Array, c::Condition)
   ...
  enviromentVars = params[:enviromentVars]
        if enviromentVars == ""
            eVars = ""
        else
            eVars = ["-v" enviromentVars]
        end

And adding this to the open command. What do you think?

from clustermanagers.jl.

amitmurthy avatar amitmurthy commented on July 21, 2024

Yes, this should work.

from clustermanagers.jl.

gcamilo avatar gcamilo commented on July 21, 2024

Ok, I'll amend my fixQueue pull request to make it take care of this.

from clustermanagers.jl.

gcamilo avatar gcamilo commented on July 21, 2024

fixed with #33

from clustermanagers.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.