Comments (4)
I think I've added test cases for most of the less covered cases.
Unfortunately we're running into the same issue on Travis that causes Gutenbergr to be blocked :( I think it's possible Project Gutenberg is blocking Travis's IPs even on these generally allowed URLs. But I'll look into it for both packages!
from tidytext.
@dgrtwo Do you know why codecov thinks there are no tests for lda_tidiers? If you click on the link:
https://codecov.io/gh/juliasilge/tidytext
and click through to the tree structure thingie, it says that lda_tidiers has 0 coverage. But there are tests for those functions?! Do you know what is going on here? 😩
from tidytext.
I was looking at the codecov thing again today, and I think I understand why codecov was not "seeing" all of the tests. In the tests for the LDA tidiers, the assignment for the LDA object is outside of the tests themselves so codecov could not tell that the calls to tidy
, etc were actually calls to tidy.LDA
and so forth. In commit 4e3c2e1 I edited the tests in test-lda-tidiers.R to specifically call tidy.LDA
and similar instead of their aliases. The code coverage is now up to 90% because now codecov knows that is what is being called.
I think we have three options here.
- Leave the test as it was and have codecov show a lower coverage than we actually have, by a lot.
- Call
tidy.LDA
,augment.LDA
in the tests, as I have it now. - Repeat the assignment of
lda <- LDA(ap, ...
and such within eachtest_that
statement, copy/paste style.
@dgrtwo, which do you think is the best option? I lean toward option 2, I think?
from tidytext.
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
from tidytext.
Related Issues (20)
- Filter Harmful Words? HOT 3
- Parts_of_speech Expected Behavior HOT 3
- unnest_tokens on large corpus with limited RAM HOT 3
- Error in qr.lm(thetasims[, k], qx) HOT 7
- Release tidytext 0.3.4 HOT 2
- Make hunspell a Suggested dependency? HOT 2
- scales::wrap_format() does not work with scale_*_reordered HOT 4
- Change to new cran checks badge URL HOT 3
- include algo of tidy autostemmer HOT 1
- Release tidytext 0.4.0 HOT 1
- Release tidytext 0.4.1 HOT 1
- Support tidy.BTM
- [Accessibility issue] Vignettes lacks alt= in plots HOT 1
- Replacement of `token = "tweets"` HOT 3
- tidytext idf negative values due to wrong counting of number of documents HOT 2
- Error in cast_dfm() function HOT 2
- Speed improvement for bind_tf_idf HOT 5
- Disregard this issue. HOT 1
- Switch over to using native pipe
- Release tidytext 0.4.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidytext.