Giter Site home page Giter Site logo

Comments (3)

abelsiqueira avatar abelsiqueira commented on September 26, 2024

Yes, these functions shouldn't have been created, I should have checked for the need of inplace.
I will try modify the script to get this automatically if I can. Essentially, if the output variables aren't arrays, then it shouldn't have to be an inplace version of it.
The second case I will have to think more carefully.

About the finite element format, I don't know much about it so I left it alone.

And about the convention, I wasn't aware of it, but I don't like it (at least in this case) because using the CUTEst order is more natural for people coming from other languages. I'm glad you're satisfied with what we got.

from cutest.jl.

abelsiqueira avatar abelsiqueira commented on September 26, 2024

I'm finalizing this fix. I'm not using nlp as argument for the functions on CUTEstModel and cutest_finalize. Also removing

  • *dimse, that might be used when we find something for finite-element format;
  • *names, which we could implement to optionally be used in CUTEstModel;
  • *vartype, for the same reason as above.

The inplace problem was also fixed, I believe.

from cutest.jl.

abelsiqueira avatar abelsiqueira commented on September 26, 2024

Fixed by #41

from cutest.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.