Tag new release?

[juliastats]

Tag new release?

[ararslan]

Sure, will do.

[ararslan]

He did indeed: #31 😄

[tkelman]

0.1.2 and master are identical

$ cat KernelDensity/versions/0.1.2/sha1
48cfa6aec1acb6de62b2aee547281293a298eeef

[ranjanan]

Ah, I see. I got a deprecation warning the first time I did Pkg.test, because of this line. Pkg.checkout made it go away, so I posted this issue here.

WARNING: symbol is deprecated, use Symbol instead.
 in depwarn(::String, ::Symbol) at ./deprecated.jl:64
 in symbol(::String, ::Vararg{String,N}) at ./deprecated.jl:30
 in @glue(::Any) at /Users/ranjan/.julia/v0.5/KernelDensity/src/KernelDensity.jl:21
 in include_from_node1(::String) at ./loading.jl:426
 in macro expansion; at ./none:2 [inlined]
 in anonymous at ./<missing>:?
 in eval(::Module, ::Any) at ./boot.jl:234
 in process_options(::Base.JLOptions) at ./client.jl:239
 in _start() at ./client.jl:318
while loading /Users/ranjan/.julia/v0.5/KernelDensity/src/KernelDensity.jl, in expression starting on line 28

[ranjanan]

Interestingly, after Pkg.free and Pkg.test I'm not able to reproduce this.

[ranjanan]

Ah, wait, I get this warning during precompilation. That's why the first Pkg.add gave me that warning.

[tkelman]

Looks like it depends on whether or not you have PyPlot or Winston installed. That @glue macro has the same precompilation issue that Requires.jl does, and should probably be replaced with something that uses whatever the small piece of Plots.jl or RecipesWhatever you're supposed to use now.

[ranjanan]

What does this have to do with PyPlot or Winston? I didn't understand your comparison.

I think just putting @compat Symbol in that line would fix this.

[tkelman]

Look at what the macro's used for.

KernelDensity.jl/src/KernelDensity.jl

Lines 28 to 29 in 48cfa6a

	@glue Winston
	@glue PyPlot

If this package did plotting in a more modern precompilation-compatible way it wouldn't need to define that macro at all.

[ranjanan]

Oh okay. So, do you think a refactor of this package to use Plots instead is required?

[tkelman]

For it to properly be precompile-compatible (and therefore for any other packages that depend on this one to be correctly precompile-compatible), yes. But at the moment you could just fix the deprecation.

[ararslan]

I'd be in favor of removing the plotting stuff from here entirely. If it belongs anywhere I would think it'd be StatPlots. At the very least we could just give an example in the readme or whatever on how to plot if a plotting package is available.

[tkelman]

It looks like StatPlots depends on this package, so that sounds ideal.

[ranjanan]

@ararslan Shall I put together a PR removing plotting entirely then?

[ararslan]

@ranjanan Sure, if you want to then go for it. 👍 I can do it if you'd rather not.

[tlnagy]

Hey @ranjanan, did you have time to get that PR together?

[ranjanan]

Now that #31 has merged, can we tag a new release please?