log1pexp(x) when x < -37

[juliastats]

log1pexp(x) when x < -37

[dmbates]

I can see how your version will be faster because it avoids the exp(-x) in oftype(exp(-x), x). You may consider adding

log1pexp_v2(x::Number) = log1pexp_v2(float(x))

to get coverage for integer arguments.

[cossio]

I would do log1pexp_v2(x::Real) = log1pexp_v2(float(x)), since we don't want to cover complex arguments.

[dmbates]

You're right. That's better.

[cossio]

Should I prepare a PR on this?

[dmbates]

Yes, please.

[cossio]

@dmbates Please see JuliaStats/StatsFuns.jl#70

[Uroc327]

If I may ask, what's the current state of this?

[devmotion]

I don't know, I just transferred the issue when log1pexp was moved from StatsFuns to LogExpFunctions. @cossio, do you plan to open a PR to LogExpFunctions that preferably also addresses the comments in JuliaStats/StatsFuns.jl#70?

[tpapp]

JuliaStats/StatsFuns.jl#70 was just closed, but a PR here is welcome.

[cossio]

I'll do a PR right after #35 is done.

[tpapp]

Great, thanks!