[feature request] modify keyboard character (font) size

[58673]

[feature request] modify keyboard character (font) size

[Spike-from-NH]

In the Settings (swipe the gear logo), in the Style section, try the setting "Label size". My preference is 1.30x.

[58673]

In the Settings (swipe the gear logo), in the Style section, try the setting "Label size".

Great.

I suggest changing the default value.

[Spike-from-NH]

As shown, I agree the default is small. But changing the default requires me to change my 1.30x on all devices to retain my preference. No; please maintain backward-compatibility!

[Spike-from-NH]

Oh, I see—You don't want to change what 1.00x means, only what value comes up initially. Then my objection is wrong.

I have keyboard height Landscape(40%,4-row layout), Portrait(30%,5-row layout), Labels 1.30x.

[bokidori]

+1
I agree with the desire for larger default label size, I also increase label size to 1.20x on my devices. Might be better to open a new issue or PR asking for larger default size.

@Spike-from-NH, backwards compatibility should be trivial. Either the default value changes from "1.0" to, ie. "1.3" (so no change to how many pixels "1.0" represents, user's set preference works unaffected), or if pixel size of "1.0" itself is modified code must be added to migrate (recalculate) the user preference to a new value. This is also quite trivial, I've implemented it a few times over the decade when extending databases with new columns, despite not being an actual developer.

In fact, I just played with the first approach on my own branch, changing Config.java line 178 and settings.xml line 48. Seems to do the trick.

[Julow]

Both approach are good :) As you have made the change, could you open a PR ?

[bokidori]

I opened a PR with the mentioned first approach - just increasing the default label size which does not affect user set preferences. Upon testing it today much longer than I'd like, I don't believe it solves the issue of label size becoming too small when keyboard height is reduced.

Could @Spike-from-NH or @58673 please mention their keyboard height and label size values used? Did labels become too small because keyboard height was reduced from default 35%?

For me:
Device 1, label size 1.3, keyboard height 27%.
Device 2, label size 1.2, keyboard height 31%.