Giter Site home page Giter Site logo

Comments (8)

jumbojett avatar jumbojett commented on August 17, 2024

Hi @BigTonni ! Even though it's not mentioned in the spec, that sounds logical. If I recall, this method was submitted by another user. Adding the header shouldn't break the flow for others. Do you mind giving it at first pass and submitting a PR?

from openid-connect-php.

BigTonni avatar BigTonni commented on August 17, 2024

Hi @jumbojett !
What is needed for this? Do I create a separate branch and push a commit with code changes for this method?

from openid-connect-php.

jumbojett avatar jumbojett commented on August 17, 2024

@BigTonni Pretty much! This guide should help. https://help.github.com/articles/creating-a-pull-request/

from openid-connect-php.

BigTonni avatar BigTonni commented on August 17, 2024

@jumbojett , share the rights for my account. I can not create a new branch for commits.

from openid-connect-php.

lordelph avatar lordelph commented on August 17, 2024

@BigTonni you need to create your own fork first - see the section in the linked article

If you don't have write access to the repository where you'd like to create a pull request, you must create a fork, or copy, of the repository first. For more information, see "Creating a pull request from a fork" and "About forks."

So, fork this repo, create a branch on your fork, push the branch to this repo.

from openid-connect-php.

BigTonni avatar BigTonni commented on August 17, 2024

@lordelph thank you! Ready.

from openid-connect-php.

jumbojett avatar jumbojett commented on August 17, 2024

Linking PR #115

from openid-connect-php.

azmeuk avatar azmeuk commented on August 17, 2024

Closed by #271

from openid-connect-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.