Allow Provider Port

[jumbojett]

Allow Provider Port

[nk2580]

Cool beans, I’ll prepare a PR when I can get some time.

Yes, feel free

[jumbojett]

@nk2580 thank you for raising this. Will you be submitting a PR?

[nk2580]

I’m considering a different approach, one of the reason I was getting frustrated was that debugging requests felt very cumbersome. What are your thoughts on replacing the http layer with guzzle?

[jumbojett]

I was getting frustrated was that debugging requests felt very cumbersome.

I'm sorry to hear that.

What are your thoughts on replacing the http layer with guzzle?

I like guzzle. In keeping with the minimalist approach - Our project strives for as few dependencies as possible. Would adding debug points via error_log help?

[nk2580]

It certainly would.. but I guess it depends on your opinion of minimalism. I guess the biggest thing for me is that the feature of non PSR HTTP requests are somewhat of an anti pattern.

I toyed with the idea of forking your repo, however in the spirit of GitHub I think it would be best to find a way to contribute.

Also testing cURL sucks! So I’ve been basically mocking the whole fetch method out, which feels wrong.

Would you be interested in supplying some guidelines for replacing the HTTP layer with something testable and PSR based?

I.e what’s your idea of minimalism as a library?

COMPLIMENT TIME

This is a great little library and is quite handy at implementing a client quickly into any project. It’s pretty much the only project out there that just works as described. It would be awesome if we could tweak it to be more useable across other projects.

[jumbojett]

I toyed with the idea of forking your repo, however in the spirit of GitHub I think it would be best to find a way to contribute.

I'm glad you chose this path!

Would you be interested in supplying some guidelines for replacing the HTTP layer with something testable and PSR based?

Here's my initial thought. Add a debug option to the current library. Add logic to the fetchURL method that will enable verbose output. Doing so would set curl_setopt($curlhandle, CURLOPT_VERBOSE, true); In addition to printing the request parameters via error_log. Thoughts?

I.e what’s your idea of minimalism as a library?

A library that has as few dependencies as possible. It prefers PHP core methods over wrapped architecture.

COMPLIMENT TIME

Thank you! Do you mind if I share this quote in the README?