Comments (6)
Cool beans, I’ll prepare a PR when I can get some time.
Yes, feel free
from openid-connect-php.
@nk2580 thank you for raising this. Will you be submitting a PR?
from openid-connect-php.
I’m considering a different approach, one of the reason I was getting frustrated was that debugging requests felt very cumbersome. What are your thoughts on replacing the http layer with guzzle?
from openid-connect-php.
I was getting frustrated was that debugging requests felt very cumbersome.
I'm sorry to hear that.
What are your thoughts on replacing the http layer with guzzle?
I like guzzle. In keeping with the minimalist approach - Our project strives for as few dependencies as possible. Would adding debug points via error_log
help?
from openid-connect-php.
It certainly would.. but I guess it depends on your opinion of minimalism. I guess the biggest thing for me is that the feature of non PSR HTTP requests are somewhat of an anti pattern.
I toyed with the idea of forking your repo, however in the spirit of GitHub I think it would be best to find a way to contribute.
Also testing cURL sucks! So I’ve been basically mocking the whole fetch method out, which feels wrong.
Would you be interested in supplying some guidelines for replacing the HTTP layer with something testable and PSR based?
I.e what’s your idea of minimalism as a library?
COMPLIMENT TIME
This is a great little library and is quite handy at implementing a client quickly into any project. It’s pretty much the only project out there that just works as described. It would be awesome if we could tweak it to be more useable across other projects.
from openid-connect-php.
I toyed with the idea of forking your repo, however in the spirit of GitHub I think it would be best to find a way to contribute.
I'm glad you chose this path!
Would you be interested in supplying some guidelines for replacing the HTTP layer with something testable and PSR based?
Here's my initial thought. Add a debug option to the current library. Add logic to the fetchURL
method that will enable verbose output. Doing so would set curl_setopt($curlhandle, CURLOPT_VERBOSE, true);
In addition to printing the request parameters via error_log
. Thoughts?
I.e what’s your idea of minimalism as a library?
A library that has as few dependencies as possible. It prefers PHP core methods over wrapped architecture.
COMPLIMENT TIME
Thank you! Do you mind if I share this quote in the README?
from openid-connect-php.
Related Issues (20)
- Bugs - Azure B2C - URL char issue HOT 2
- Issue when running composer require jumbojett/openid-connect-php HOT 1
- signout() does not sign me out of my application HOT 9
- requestClientCredentialsToken invalid scope in Keycloak HOT 2
- Throwed error if the server returns one is complete HOT 1
- OpenID Connect can return an id_token as part of the refresh_token grant type
- Keycloak 22.0 not supported? HOT 5
- Release new major ... HOT 1
- Cant get codeVerifier in redirectUri if we make authorization flow using PKCE HOT 1
- SERVER_PORT always causes port in redirect URL HOT 4
- Redirect doesn't remove state, session_state, and code params HOT 2
- Support dropped for phpseclib 2.*? HOT 2
- Invalid Client - Connect Token HOT 1
- Support for `id_token_signing_alg_values_supported` HOT 1
- Return types are too strict
- requestTokenExchange error Passing null to parameter #2 of http_build_query
- Debug Mode ? HOT 1
- scopes attribut are NULL HOT 1
- could you maybe help out the heimdall project to add oidc support?
- $verifiedClaims is no array but an object
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openid-connect-php.