Giter Site home page Giter Site logo

Comments (11)

christiaangoossens avatar christiaangoossens commented on July 18, 2024 1

I would like to add that this library (without modifications) does not work with Azure AD, although it has been OpenID Certified. This is due to the fact that the provider (discovery) URL given to OpenIDConnectClient is on the https://login.microsoftonline.com/ domain (see: https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-protocols-openid-connect-code), while the token issuer is https://sts.windows.net/ (https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-token-and-claims#idtokens). This does (possibly) not apply to version 2 tokens.

It will work if you change the provider URL between redirecting to the authorize endpoint and the validation of the JWT token.

I'll add this to the relevant wiki page.

from openid-connect-php.

jumbojett avatar jumbojett commented on July 18, 2024

Good question @zmon. I'm interested as well. I'd like to add a list to the documentation. Thanks for starting this thread.

from openid-connect-php.

billsimon avatar billsimon commented on July 18, 2024

Re: the Google integration. Like @zmon I just use 'accounts.google.com' for the provider_url variable. The README shows a scheme and hostname like https://accounts.google.com. Which is it? I think when I first set it up I used https://accounts.google.com and it didn't work so I went with the bare name of accounts.google.com. Just today, I found that the claims validation was failing because Google is sending back the https://accounts.google.com address as the issuer and this doesn't match what's in the constructor.

from openid-connect-php.

zmon avatar zmon commented on July 18, 2024

@billsimon I just went back to my code (which has not changed since testing my pull request) and found that accounts.google.com failed... Adding the https fixed it. They must of changed something.

from openid-connect-php.

zmon avatar zmon commented on July 18, 2024

@jumbojett Added a wiki page for a list of providers.

from openid-connect-php.

jricher avatar jricher commented on July 18, 2024

Google's in the middle of testing for certification with the OpenID Foundation, so I wouldn't be surprised if they were fixing a bunch of slightly-off-spec things in the process (like the issuer value which is supposed to always start with https).

from openid-connect-php.

billsimon avatar billsimon commented on July 18, 2024

Nice timing... I guess it's always the middle of the afternoon somewhere in the world. OK, thanks for the confirmation. I was puzzled.

from openid-connect-php.

zmon avatar zmon commented on July 18, 2024

A list of implementations have been granted certification by OpenID

from openid-connect-php.

jumbojett avatar jumbojett commented on July 18, 2024

A list of implementations have been granted certification by OpenID
@zmon Good find!

from openid-connect-php.

DeepDiver1975 avatar DeepDiver1975 commented on July 18, 2024

@christiaangoossens Mind sharing which changes are explicit necessary to get this working? THX

from openid-connect-php.

christiaangoossens avatar christiaangoossens commented on July 18, 2024

@DeepDiver1975 As far as I remember, I just switched out the issuer before the checking part.

from openid-connect-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.